Reland: Multiview pipeline #47234
Merged
Reland: Multiview pipeline #47234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4a65910.
loic-sharma
approved these changes
Oct 23, 2023
dkwingsmt
added
autosubmit
zanderso
added a commit
that referenced
this pull request
Oct 23, 2023
Reverts #47234 Failures like https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/186568/overview making the tree red.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2023
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
This PR relands #44473. The previous PR was immediately reverted after merging because we found that the PR could cause illegal renders to be skipped on debug builds but crash the app on release builds. This PR makes the `Animator::Render` skip illegal renders as well. This should not be the final shape of this feature, and thus a TODO is added. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2023
…137107) flutter/engine@abeab89...0bd7031 2023-10-23 zanderso@users.noreply.github.com Revert "Reland: Multiview pipeline " (flutter/engine#47237) 2023-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 53fee35b299f to 901e92d10627 (5 revisions) (flutter/engine#47235) 2023-10-23 dkwingsmt@users.noreply.github.com Reland: Multiview pipeline (flutter/engine#47234) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
The last attempt #47234 was reverted because there was another test merged in the meantime that violates the rule added in this PR. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relands #44473.
The previous PR was immediately reverted after merging because we found that the PR could cause illegal renders to be skipped on debug builds but crash the app on release builds. This PR makes the
Animator::Renderskip illegal renders as well. This should not be the final shape of this feature, and thus a TODO is added.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.