Build embedder for Windows #4730
Conversation
|
cc @chinmaygarde for review |
|
When https://fuchsia-review.googlesource.com/c/garnet/+/131115 gets merged I'll remove my workaround in DirectoryAssetBundle |
|
Updated, PTAL |
|
LGTM ! |
ghost
mentioned this pull request
|
Rebased |
Several uses of designated initializers, which are non-standard, were removed. FLUTTER_EXPORT is defined as dllexport in embedder.cc and dllimport otherwise. SAFE_ACCESS uses decltype instead of non-standard __typeof__. Required libraries (iphlpapi and rpcrt4) are linked into embedder_unittests and flutter_engine on Windows.
Fixes embedder unit test on Windows
Two bugs: To open a directory with CreateFile, FILE_FLAG_BACKUP_SEMANTICS needs to be specified. GetFinalPathNameByHandle returns a UNC path, so forward slashes need to be converted to backslashes.
|
Rebased again |
|
/cc @chinmaygarde @jason-simmons for review now that the shell refactor has landed. @ds84182 it looks like there are some new minor merge conflicts :-/ |
|
On it. This looks great. I'll fix up the merge conflicts and attempt to land this as soon as the beta 3 stuff is done. |
|
@chinmaygarde any news? |
|
All patches required to unblock Windows embedder builds locally and on the bots have landed. The buildbots now test and upload Windows artifacts on each commit. Instructions for accessing these artifacts have been added to the wiki page. @ds84182: Thank you for your patience while I was retooling the shell and the bots. Please consider adding yourself to the AUTHORS file. Thanks all. |
|
Thanks! Will do 😊 |
These changes allow the embedder DLL to build on Windows.
Also includes a workaround for DirectoryAssetBundle since FXL doesn't open files with O_BINARY.