List missing core lib bigint_patch.dart source for new Bigint implementation #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 2, 2018
…ntation." The change was reverted (thanks Slava) because gen_snapshot was failing to find the core lib class _BigIntImpl on flutter. The PR flutter/engine#4735 fixed that issue on flutter. Change-Id: Id6863d79f7fdb17f0076b63b0168394d5e95ec8d Reviewed-on: https://dart-review.googlesource.com/44660 Reviewed-by: Alexander Markov <alexmarkov@google.com>
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 9, 2018
… implementation."" This reverts commit be62fff. Reason for revert: See #32465 Original change's description: > Reland "[VM runtime] Switch intrinsics from old to new Bigint implementation." > > The change was reverted (thanks Slava) because gen_snapshot was failing to > find the core lib class _BigIntImpl on flutter. > The PR flutter/engine#4735 fixed that issue on flutter. > > Change-Id: Id6863d79f7fdb17f0076b63b0168394d5e95ec8d > Reviewed-on: https://dart-review.googlesource.com/44660 > Reviewed-by: Alexander Markov <alexmarkov@google.com> TBR=alexmarkov@google.com,regis@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I412f5143442ca6ad43784b037c01fcf9bb42c348 Reviewed-on: https://dart-review.googlesource.com/45800 Reviewed-by: Zach Anderson <zra@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Zach Anderson <zra@google.com>
reed-at-google
pushed a commit
to reed-at-google/engine
that referenced
this pull request
Mar 14, 2018
…ntation (flutter#4735) * work in progress * work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.