Move third_party/stb to flutter/third_party.
#48845
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -6,9 +6,9 @@ | |||
|
|
|||
| #include "flutter/fml/macros.h" | |||
| #include "flutter/fml/mapping.h" | |||
| #include "flutter/third_party/stb/stb_truetype.h" | |||
There was a problem hiding this comment.
I think that leaving the include path as is should hopefully still work. I'm a bit worried that the include rewriter that imports the source into the internal repo might be confused by this change.
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/48845, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
…139939) flutter/engine@4c30919...5c1f13e 2023-12-11 matanlurey@users.noreply.github.com Move `third_party/stb` to `flutter/third_party`. (flutter/engine#48845) 2023-12-11 chillers@google.com [ci.yaml] Add DEPS to emulator tests runIf (flutter/engine#48885) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
As part of eliminating the Flutter buildroot (flutter/flutter#67373), we are moving all third-party dependencies from
//third_partyto//flutter/third_party.