libtxt: render fake bold text if a bold font is not available #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
reviewed
Apr 4, 2018
third_party/txt/src/txt/paragraph.cc
Outdated
| size_t index) { | ||
| class GlyphTypeface { | ||
| public: | ||
| GlyphTypeface(const sk_sp<SkTypeface>& typeface, minikin::FontFakery fakery) |
There was a problem hiding this comment.
const sk_sp<SkTypeface>& and then copying is odd. sk_sp<SkTypeface> with an std::move into the ivar.
chinmaygarde
approved these changes
Apr 4, 2018
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Apr 5, 2018
Includes: * Revert "Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9" (flutter/engine#4936) * libtxt: render fake bold text if a bold font is not available (flutter/engine#4933) * Set FlutterTexture copyPixelBuffer return nullable (flutter/engine#4934) * Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 (flutter/engine#4929)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2018
Includes: * Revert "Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9" (flutter/engine#4936) * libtxt: render fake bold text if a bold font is not available (flutter/engine#4933) * Set FlutterTexture copyPixelBuffer return nullable (flutter/engine#4934) * Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 (flutter/engine#4929)
harrisonturton
pushed a commit
to harrisonturton/flutter
that referenced
this pull request
Apr 5, 2018
Includes: * Revert "Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9" (flutter/engine#4936) * libtxt: render fake bold text if a bold font is not available (flutter/engine#4933) * Set FlutterTexture copyPixelBuffer return nullable (flutter/engine#4934) * Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 (flutter/engine#4929)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * Revert "Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9" (flutter/engine#4936) * libtxt: render fake bold text if a bold font is not available (flutter/engine#4933) * Set FlutterTexture copyPixelBuffer return nullable (flutter/engine#4934) * Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 (flutter/engine#4929)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#16149