Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in geometry.cc#ComputeUVGeometryForRect. #49986

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

matanlurey
Copy link
Contributor

Follow up to #49910 (review).

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2024
@matanlurey matanlurey requested a review from flar January 23, 2024 22:47
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry I was late in noticing it in the original PR...

@auto-submit auto-submit bot merged commit 7c592db into flutter:main Jan 24, 2024
28 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 24, 2024
…142108)

flutter/engine@700235c...7c592db

2024-01-24 matanlurey@users.noreply.github.com Fix a typo in `geometry.cc#ComputeUVGeometryForRect`. (flutter/engine#49986)
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from be4b398b4f2e to 1af4f1216478 (1 revision) (flutter/engine#49993)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Status: ✅ Done
2 participants