Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't strip debug symbols by default from android builds #50443

Closed
wants to merge 4 commits into from
Closed

Don't strip debug symbols by default from android builds #50443

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a37ae1
Update gn
gmackall Feb 7, 2024
ea412d5
Merge branch 'main' into default_non_stripped
gmackall Feb 13, 2024
9837b9d
Merge branch 'main' into default_non_stripped
gmackall Feb 14, 2024
3312fb1
Merge branch 'main' into default_non_stripped
gmackall Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,7 @@ def parse_args(args):

parser.add_argument(
'--stripped',
default=True,
default=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we scope this only to Android?

Right now this is applying to all builds on all platforms.

action='store_true',
help='Strip debug symbols from the output. This defaults to true and has no effect on iOS.'
)
Expand Down