-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move boringssl
to flutter/third_party
.
#50601
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The golden diffs are concerning but unrelated to this PR.
Golden file changes are available for triage from new commit, Click here to view. |
As ready as it's ever going to be.
2024-02-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mZP8LxbhYHstUxmxd... to fXqP_YC4zTp9G2hA5... (flutter/engine#50680) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from b6201d9c2f73 to 85ab600a9519 (1 revision) (flutter/engine#50679) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from f1b1fa85a1be to 5e442dc80903 (1 revision) (flutter/engine#50678) 2024-02-15 chinmaygarde@google.com Use a GN variable (dart_src) to reference the location of the Dart checkout. (flutter/engine#50624) 2024-02-15 matanlurey@users.noreply.github.com Add a &right_filter=params to the Skia Gold links. (flutter/engine#50675) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 2d5cf67614d0 to b6201d9c2f73 (2 revisions) (flutter/engine#50674) 2024-02-15 matanlurey@users.noreply.github.com Disable Android API v28 tests on CI. (flutter/engine#50672) 2024-02-15 matanlurey@users.noreply.github.com Use modern concurrency constructs. (flutter/engine#50671) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 322e34dc53f6 to f1b1fa85a1be (1 revision) (flutter/engine#50670) 2024-02-15 matanlurey@users.noreply.github.com Move boringssl to flutter/third_party. (flutter/engine#50601)
2024-02-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mZP8LxbhYHstUxmxd... to fXqP_YC4zTp9G2hA5... (flutter/engine#50680) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from b6201d9c2f73 to 85ab600a9519 (1 revision) (flutter/engine#50679) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from f1b1fa85a1be to 5e442dc80903 (1 revision) (flutter/engine#50678) 2024-02-15 chinmaygarde@google.com Use a GN variable (dart_src) to reference the location of the Dart checkout. (flutter/engine#50624) 2024-02-15 matanlurey@users.noreply.github.com Add a &right_filter=params to the Skia Gold links. (flutter/engine#50675) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 2d5cf67614d0 to b6201d9c2f73 (2 revisions) (flutter/engine#50674) 2024-02-15 matanlurey@users.noreply.github.com Disable Android API v28 tests on CI. (flutter/engine#50672) 2024-02-15 matanlurey@users.noreply.github.com Use modern concurrency constructs. (flutter/engine#50671) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 322e34dc53f6 to f1b1fa85a1be (1 revision) (flutter/engine#50670) 2024-02-15 matanlurey@users.noreply.github.com Move boringssl to flutter/third_party. (flutter/engine#50601)
As ready as it's ever going to be.