Shift //third_party/icu to //flutter/third_party #50924
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
changed the title
zanderso
force-pushed
the
move-more-deps
branch
from
c7061f7
to
7e85d25
Compare
zanderso
added
the
autosubmit
…144071) flutter/engine@ca24520...7380422 2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from 9d8d3f053775 to 45b38664b4ed (1 revision) (flutter/engine#50926) 2024-02-23 matanlurey@users.noreply.github.com Refactor Android `scenario_app` to remove shell entrypoint, simplify. (flutter/engine#50922) 2024-02-23 737941+loic-sharma@users.noreply.github.com [Windows] Add helper for headless integration tests (flutter/engine#50885) 2024-02-23 zanderso@users.noreply.github.com Shift //third_party/icu to //flutter/third_party (flutter/engine#50924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
This has caused https://autoroll.skia.org/r/icu-sdk-flutter-engine to start failing. Do we need to reconfigure or remove the roller? |
|
Yes. We need to reconfigure it. I don't remember where that config lives. Would you mind pinging it to an internal chat? Thanks for the heads up =) |
Modify build script because the path to icu package path has been changed. flutter#50924
Modify build script because the path to icu package path has been changed. flutter#50924
Modify build script because the path to icu package path has been changed. flutter#50924
For flutter/flutter#67373