Fix a few issues rendering text with Skwasm. #51074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes flutter/flutter#141001 This also fixes flutter/flutter#143743 * We need to always call `setStrutEnabled(true)` on `StrutStyle`. * `getLineMetricsAt` had reversed ternary logic. * Ported unit tests from CanvasKit over to UI to cover Skwasm and HTML * The HTML renderer should return 0 line metrics for an empty paragraph.
mdebbar
approved these changes
Feb 29, 2024
Comment on lines
+750
to
+752
| if (ui.ParagraphBuilder.shouldDisableRoundingHack) { | ||
| paragraphStyleSetApplyRoundingHack(handle, false); | ||
| } |
There was a problem hiding this comment.
Not sure I understand this. Why not:
Suggested change
| if (ui.ParagraphBuilder.shouldDisableRoundingHack) { | |
| paragraphStyleSetApplyRoundingHack(handle, false); | |
| } | |
| paragraphStyleSetApplyRoundingHack( | |
| handle, | |
| !ui.ParagraphBuilder.shouldDisableRoundingHack, | |
| ); |
There was a problem hiding this comment.
Because there is no reason to invoke this API when shoudlDisableRoundingHack is false, since the rounding hack is true by default.
There was a problem hiding this comment.
Worth putting a comment above this code?
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 29, 2024
…144419) flutter/engine@bb6c6a0...7e8fefe 2024-02-29 kevmoo@users.noreply.github.com [web] Drop noisy prints from bootstrapping logic (flutter/engine#51097) 2024-02-29 jacksongardner@google.com Fix a few issues rendering text with Skwasm. (flutter/engine#51074) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes flutter/flutter#141001
This also fixes flutter/flutter#143743
setStrutEnabled(true)onStrutStyle.getLineMetricsAthad reversed ternary logic.and HTMLThe HTML renderer should return 0 line metrics for an empty paragraph.