Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git hooks on Windows #51203

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Mar 5, 2024

Windows does not pre-install python3. Previously Windows users would just use Python from depot tools, but this was broken by #51156.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso
Copy link
Member

zanderso commented Mar 5, 2024

Whoops. Can you verify that this still works on mac and Linux?

@loic-sharma
Copy link
Member Author

loic-sharma commented Mar 5, 2024

@zanderso Verified.

  • Linux
    • post-checkout
    • post-merge
    • pre-rebase
    • pre-push
      • ⚠️ On a clean Linux machine this throws:

        Checking Python formatting...
        To fix, run `et format` or:
        
        git apply <<DONE
          /home/loic/code/f/engine/src/flutter/tools/gn
        Traceback (most recent call last):
          File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
            return _run_code(code, main_globals, None,
          File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
            exec(code, run_globals)
          File "/home/loic/code/f/engine/src/flutter/third_party/yapf/yapf/__main__.py", line 16, in <module>
            import yapf
          File "/home/loic/code/f/engine/src/flutter/third_party/yapf/yapf/__init__.py", line 35, in <module>
            from yapf.yapflib import errors
          File "/home/loic/code/f/engine/src/flutter/third_party/yapf/yapf/yapflib/errors.py", line 16, in <module>
            from lib2to3.pgen2 import tokenize
        ModuleNotFoundError: No module named 'lib2to3'
        
        DONE
        
        Checking for trailing whitespace on 1 source file...
        
        
  • macOS
    • post-checkout
    • post-merge
    • pre-rebase
    • pre-push

Sorry for the delay, I didn't have a Linux machine setup at the office.

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Hixie
Copy link
Contributor

Hixie commented Mar 5, 2024

test-exempt: we'll find out about this being broken really quickly when it matters

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2024
@auto-submit auto-submit bot merged commit dacec1c into flutter:main Mar 5, 2024
26 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 6, 2024
…144653)

flutter/engine@49bc157...effcf97

2024-03-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (#51209)" (flutter/engine#51217)
2024-03-05 30870216+gaaclarke@users.noreply.github.com [Impeller] implement blur style solid (flutter/engine#50892)
2024-03-05 xilaizhang@google.com [g3 roll] Revert "Remove unused drone_dimension field" (flutter/engine#51214)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 17677914dabf to 37947aec8c5c (5 revisions) (flutter/engine#51211)
2024-03-05 737941+loic-sharma@users.noreply.github.com Fix git hooks on Windows (flutter/engine#51203)
2024-03-05 bdero@google.com [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51209)
2024-03-05 bdero@google.com [Impeller] Fix convex triangulation winding bug for multi-contour paths. (flutter/engine#51198)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 875b356e4d96 to 17677914dabf (2 revisions) (flutter/engine#51207)
2024-03-05 gspencergoog@users.noreply.github.com Skip configuration dependency if unit tests are disabled (flutter/engine#51179)
2024-03-05 chinmaygarde@google.com [Impeller] Implement YUV texture import and sampling for video player frames. (flutter/engine#50730)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
3 participants