Copy the flutter_gpu package into the engine artifacts. #51365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christopherfujino Will adding new artifacts here confuse any tests in the framework repo? The code signing tests? |
Yeah, if this is a binary then I think we need to add a rule to codesign it, I think here: https://github.com/flutter/flutter/wiki/code-signing-metadata#add--update-code-signing-metadata If these are already codesigned, then this should be fine. |
|
This is purely a Dart package and doesn't contain any native binaries. So I think we're good? |
chinmaygarde
approved these changes
Mar 12, 2024
|
Gonna give this a land and see how it shakes out in the roll. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 13, 2024
…145062) flutter/engine@ea848c3...285b9fb 2024-03-13 bdero@google.com Copy the flutter_gpu package into the engine artifacts. (flutter/engine#51365) 2024-03-13 chinmaygarde@google.com [Impeller] Make masks type safe. (flutter/engine#51369) 2024-03-12 bdero@google.com Remove early Flutter GPU prototype from ui/experiments. (flutter/engine#51367) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#131711.