Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JSBoxedDartObject to JSAny #51634

Merged
merged 1 commit into from Mar 26, 2024
Merged

Commits on Mar 22, 2024

  1. Change JSBoxedDartObject to JSAny

    Closes dart-lang/sdk#55256
    
    flutter@fda5c69
    added code to avoid the less performant boxing of JSBoxedDartObject
    and instead use backend-specific logic to externalize and internalize
    the UniqueRef until we get a better solution from dart:js_interop.
    On the JS backends, this relied on casting to and from JSAny, as its
    representation type is just Object. However, this callback that takes
    in the UniqueRef as an arg is still JSBoxedDartObject, leading to a
    cast failure on the JS backends.
    
    The fix is to use JSAny. On dart2wasm, this makes no difference, as the
    underlying representation type does not change.
    srujzs committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    90b03a4 View commit details
    Browse the repository at this point in the history