Roll Skia from 4281f51749b2 to a86861d21ae1 (23 revisions) #51998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/4281f51749b2..a86861d21ae1 2024-04-09 brianosman@google.com Revert "Migrate SkParagraph's tests etc to provide SkUnicode" 2024-04-09 jvanverth@google.com [graphite] Fix linear filter inset variable names. 2024-04-09 robertphillips@google.com [graphite] Explicitly hold SkBlendModes in PaintOptions 2024-04-09 olv@google.com Add VkComponentMapping to VulkanYcbcrConversionInfo 2024-04-09 kjlubick@google.com Add one more case for SkColorType switch 2024-04-09 jvanverth@google.com [graphite] Add linear filter inset for YUV. 2024-04-09 robertphillips@google.com [graphite] Fix up PaintOptions::toKey 2024-04-09 kjlubick@google.com Migrate SkParagraph's tests etc to provide SkUnicode 2024-04-09 senorblanco@chromium.org Revert "Reland "Graphite/Dawn: Eliminate Device::Tick() usages."" 2024-04-09 kjlubick@google.com Add ganesh_metal target 2024-04-09 bungeman@google.com [colrv1] Keep glyphs on test canvas 2024-04-09 kjlubick@google.com Minor clang-tidy suggestions 2024-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8072102bca4a to 57a0fe0778df (1 revision) 2024-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e6b3a4e3da47 to b09312b32b9c 2024-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from fd9ef76964cc to e6b3a4e3da47 (10 revisions) 2024-04-09 michaelludwig@google.com [graphite] Consolidate Device/Surface factory functions 2024-04-08 johnstiles@google.com Fix minor bugs in the SkSL PrettyPrint algorithm. 2024-04-08 aaclarke@google.com Adds support for BGRA10_XR. 2024-04-08 brianosman@google.com Remove old (unused) skia_launcher 2024-04-08 jvanverth@google.com [graphite] Fix subsetting for UV planes. 2024-04-08 johnstiles@google.com Remove GLSL/Metal/WGSL indentation in release mode. 2024-04-08 kjlubick@google.com Enforce IWYU on src/gpu/tesselate 2024-04-08 kjlubick@google.com Fix shaping in GN builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
force-pushed
the
skia-flutter-autoroll-341a3325-b1be-48b7-a984-89570b1492c7-1712690946
branch
from
981f089
to
f5bbf9b
Compare
skia-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Apr 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 9, 2024
…146527) flutter/engine@5dca50d...e4e2748 2024-04-09 skia-flutter-autoroll@skia.org Roll Skia from 4281f51749b2 to a86861d21ae1 (23 revisions) (flutter/engine#51998) 2024-04-09 bdero@google.com [Impeller] Remove StC flag. (flutter/engine#51992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
fixes flutter/flutter#145933 This required that we moved the golden image tests to arm64 since the wide gamut tests would now require BGRA10_XR and that's only available to arm64. tests: in framework repo https://github.com/flutter/flutter/tree/master/dev/integration_tests/wide_gamut_test. There was a test added to that suite specifically for this case when we turned off BGRA10_XR the first time. This has a dependency on #51998 which includes the necessary skia change. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
added a commit
that referenced
this pull request
Apr 15, 2024
Reverts: #52019 Initiated by: jonahwilliams Reason for reverting: I believe the tree failures are due to changes in the build configuration this file introduced. Original PR Author: gaaclarke Reviewed By: {jonahwilliams} This change reverts the following previous change: fixes flutter/flutter#145933 This required that we moved the golden image tests to arm64 since the wide gamut tests would now require BGRA10_XR and that's only available to arm64. tests: in framework repo https://github.com/flutter/flutter/tree/master/dev/integration_tests/wide_gamut_test. There was a test added to that suite specifically for this case when we turned off BGRA10_XR the first time. This has a dependency on #51998 which includes the necessary skia change. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
skia-flutter-autoroll
deleted the
skia-flutter-autoroll-341a3325-b1be-48b7-a984-89570b1492c7-1712690946
branch
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146527) flutter/engine@5dca50d...e4e2748 2024-04-09 skia-flutter-autoroll@skia.org Roll Skia from 4281f51749b2 to a86861d21ae1 (23 revisions) (flutter/engine#51998) 2024-04-09 bdero@google.com [Impeller] Remove StC flag. (flutter/engine#51992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/4281f51749b2..a86861d21ae1
2024-04-09 brianosman@google.com Revert "Migrate SkParagraph's tests etc to provide SkUnicode"
2024-04-09 jvanverth@google.com [graphite] Fix linear filter inset variable names.
2024-04-09 robertphillips@google.com [graphite] Explicitly hold SkBlendModes in PaintOptions
2024-04-09 olv@google.com Add VkComponentMapping to VulkanYcbcrConversionInfo
2024-04-09 kjlubick@google.com Add one more case for SkColorType switch
2024-04-09 jvanverth@google.com [graphite] Add linear filter inset for YUV.
2024-04-09 robertphillips@google.com [graphite] Fix up PaintOptions::toKey
2024-04-09 kjlubick@google.com Migrate SkParagraph's tests etc to provide SkUnicode
2024-04-09 senorblanco@chromium.org Revert "Reland "Graphite/Dawn: Eliminate Device::Tick() usages.""
2024-04-09 kjlubick@google.com Add ganesh_metal target
2024-04-09 bungeman@google.com [colrv1] Keep glyphs on test canvas
2024-04-09 kjlubick@google.com Minor clang-tidy suggestions
2024-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8072102bca4a to 57a0fe0778df (1 revision)
2024-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e6b3a4e3da47 to b09312b32b9c
2024-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from fd9ef76964cc to e6b3a4e3da47 (10 revisions)
2024-04-09 michaelludwig@google.com [graphite] Consolidate Device/Surface factory functions
2024-04-08 johnstiles@google.com Fix minor bugs in the SkSL PrettyPrint algorithm.
2024-04-08 aaclarke@google.com Adds support for BGRA10_XR.
2024-04-08 brianosman@google.com Remove old (unused) skia_launcher
2024-04-08 jvanverth@google.com [graphite] Fix subsetting for UV planes.
2024-04-08 johnstiles@google.com Remove GLSL/Metal/WGSL indentation in release mode.
2024-04-08 kjlubick@google.com Enforce IWYU on src/gpu/tesselate
2024-04-08 kjlubick@google.com Fix shaping in GN builds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md