[et] Adds --lto flag to build. Plumbs verbose flag differently. #52021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 10, 2024
…146605) flutter/engine@beee02b...91ba235 2024-04-10 zanderso@users.noreply.github.com Adds iOS builds to local_engine.json (flutter/engine#52027) 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from df6d08abb447 to 91e0c0f4bf41 (3 revisions) (flutter/engine#52026) 2024-04-10 jonahwilliams@google.com [Android] post image task to main handler. (flutter/engine#52025) 2024-04-10 zanderso@users.noreply.github.com [et] Adds --lto flag to build. Plumbs verbose flag differently. (flutter/engine#52021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146605) flutter/engine@beee02b...91ba235 2024-04-10 zanderso@users.noreply.github.com Adds iOS builds to local_engine.json (flutter/engine#52027) 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from df6d08abb447 to 91e0c0f4bf41 (3 revisions) (flutter/engine#52026) 2024-04-10 jonahwilliams@google.com [Android] post image task to main handler. (flutter/engine#52025) 2024-04-10 zanderso@users.noreply.github.com [et] Adds --lto flag to build. Plumbs verbose flag differently. (flutter/engine#52021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added a commit
that referenced
this pull request
Apr 23, 2024
…2339) #52021 introduced a bug where `ci` build could only be specified when also passing the `--verbose` flag. This PR fixes the issue so that by default the `help` message will only show `ci` builds when `--verbose` is passed to `help`, but the `ci` builds can be specified even without the `--verbose` flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things. First, in many of the
cibuilds, LTO is enabled by default. This is usually not what we want when doing local builds, so this PR adds an--ltoflag to thebuildcommand which is disabled by default, causing--no-ltoto be passed to GN. When--ltois passed to thebuildcommand,--ltois passed to GN, which results in the build using LTO.Second, this PR eagerly parses the
--verboseflag out of the command line so that help messages can optionally show less information. In particular, in this PR,ciandweb_testbuilds are only displayed byhelp buildwhen--verboseis passed to thehelpcommand. There's some extra text in the help message as well indicating that passing--verbosetohelpwill show more builds.