Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "Compile libcxx and libcxxabi for Android (#6886)" #6919

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Reland "Compile libcxx and libcxxabi for Android (#6886)" #6919

merged 2 commits into from
Dec 10, 2018

Conversation

goderbauer
Copy link
Member

This reverts commit 983d70e.

This will require flutter/buildroot#193.

@goderbauer
Copy link
Member Author

Size of libflutter.so at current tip of tree (5c81474):

4429346630 10488 -rwxr-xr-x   1 goderbauer  eng  5368024 Nov 21 09:58 libflutter.so
4429346656  5696 -rw-r--r--   1 goderbauer  eng  2915442 Nov 21 09:58 libflutter.zip

With this change merged in:

4429393679 10256 -rwxr-xr-x   1 goderbauer  eng  5247784 Nov 21 11:12 libflutter.so
4429393693  5600 -rw-r--r--   1 goderbauer  eng  2864777 Nov 21 11:12 libflutter.zip

That's a size reduction of 117.4 KB (uncompressed) or 49.5 KB (compressed).

@goderbauer goderbauer merged commit 3fd6636 into flutter:master Dec 10, 2018
@goderbauer goderbauer deleted the relandlibcxx branch December 10, 2018 17:06
goderbauer added a commit that referenced this pull request Dec 10, 2018
@goderbauer
Revert "Reland "Compile libcxx and libcxxabi for Android (#6886)" (#6919
36c0294 
)"

This reverts commit 3fd6636.
@goderbauer goderbauer mentioned this pull request Dec 10, 2018
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
f947c0a 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
a14def6 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
8557131 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
fa92094 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
721746e 
…" (flutter/engine#6919)
This was referenced Dec 11, 2018
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
60d0710 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
232e001 
…" (flutter/engine#6919)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
5a48750 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
7cf0760 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
461cd92 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
4b836d9 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
1a93f03 
…" (flutter/engine#6919)
GaryQian pushed a commit to GaryQian/engine that referenced this pull request Dec 11, 2018
@goderbauer @GaryQian
Reland "Compile libcxx and libcxxabi for Android (flutter#6886)" (flu…
824dec1 
…tter#6919)

This reverts commit 983d70e.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
746ee69 
…" (flutter/engine#6919)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
d515423 
…" (flutter/engine#6919)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
64f1874 
…" (flutter/engine#6919)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2018
@engine-flutter-autoroll
3fd6636 Reland "Compile libcxx and libcxxabi for Android (flutter#6886)…
178a8a2 
…" (flutter/engine#6919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
cla: yes size
Projects
None yet
Milestone
No milestone
3 participants
@goderbauer @chinmaygarde @googlebot