Remove unnecessary includes of Skia headers. #7189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianosman
approved these changes
Dec 12, 2018
|
@brianosman, can you land this? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2018
…#7189) (#25282) flutter/engine@abb1d3a...e5195ee git log abb1d3a..e5195ee --no-merges --oneline e5195ee Remove unnecessary includes of Ganesh headers (flutter/engine#7189) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
DaveShuckerow
added a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2018
…ter/engine#7189) (#25282)" This reverts commit f198d66.
DaveShuckerow
added a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2018
…#25288) * Revert "e5195ee47 Remove unnecessary includes of Ganesh headers (flutter/engine#7189) (#25282)" This reverts commit f198d66. * Revert "Validate style in TextField (#24587)" This reverts commit 9a8e2f0. * Revert "Allow snippets tool to be run from arbitrary CWDs (#25243)" This reverts commit 4a110b6. * Revert "Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)" This reverts commit e29b023. * Revert "Add ipv6 and observatory port support to the attach command. (#24537)" This reverts commit 9150b3f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chinmaygarde, Eventually Skia wants to hide GrTexture.h. There were a few unneeded includes of this filein Flutter engine, along with some other unnecessary includes.