Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SkColorSpaceXformCanvas, use color-managed SkSurfaces instead #7548

Merged
merged 3 commits into from Jan 22, 2019

Conversation

brianosman
Copy link
Contributor

No description provided.

@brianosman
Copy link
Contributor Author

Behavior (visual) changes should be very minor. Things that are to be expected:

  • A few things were not color managed correctly by the transform canvas (color emoji, some color filters). Those will be handled correctly with the tagged surfaces (although we're always transforming to sRGB, so nothing should change until we target a wider gamut).
  • Image filtering will happen in the source color space, rather than the destination. Very minor.
  • The transform canvas did caching of images in the destination color space. Now, the conversion happens at draw time. If there are performance issues, images can be pre-converted to the destination with makeColorSpace().

@brianosman
Copy link
Contributor Author

The new expected PNG is visually identical, but now includes the 'sRGB' tag in the PNG header. This reflects the fact that the image being encoded has a color space attached. Previously, we produced images with a null color space, so we never included color management information in the files we encoded.

@brianosman brianosman merged commit 50ddc37 into flutter:master Jan 22, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2019
dnfield added a commit to flutter/goldens that referenced this pull request Jan 23, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2019
@brianosman brianosman deleted the tagged-surfaces branch April 16, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants