Buffer lifecycle in WindowData #7999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally LGTM from a Java developer's perspective. But please wait for an engine side LGTM as well. I'd like to confirm, are we sure the window is the right place for lifecycle data? I know it's an easy place to add a property, but is that the logical place for it from a Flutter app perspective? |
|
WindowData is currently the location where we store all data that should be cached before the dart isolate is initialized. This data also persists on a hot restart. I'll verify with jason or chinmay about the placement though. |
jason-simmons
approved these changes
Mar 1, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2019
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Mar 1, 2019
GaryQian
added a commit
that referenced
this pull request
Mar 1, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 2, 2019
flutter/engine@6604216...39c46de git log 6604216..39c46de --no-merges --oneline 39c46de Revert "Buffer lifecycle in WindowData (#7999)" (flutter/engine#8010) 293cfca Guard against using Android API not defined in API level 16 & 17 (flutter/engine#8006) d7e0bc1 Roll src/third_party/skia 71a23d4195d9..e1f5b644656f (8 commits) (flutter/engine#8004) 0b17401 Buffer lifecycle in WindowData (flutter/engine#7999) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop the roller if necessary.
GaryQian
added a commit
that referenced
this pull request
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This buffers the lifecycle state in WindowData and provides a way for the framework bindings to initialize the state to the buffered value at startup.
Part of the fix for flutter/flutter#2716. Framework side is flutter/flutter#28688