Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop android_sdk_downloader in favor of cipd #8087

Merged
merged 4 commits into from Mar 9, 2019

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 8, 2019

Fixes flutter/flutter#27967

CIPD was actually much easier to implement for this than I initially thought. I've created the packages for Linux and Mac here: https://chrome-infra-packages.appspot.com/p/flutter/android

I've also added bash scripts to help with creating new ones in the future.

@dnfield
Copy link
Contributor Author

dnfield commented Mar 9, 2019

This will fail until we either rebuild the GKE container or land #8098

It's hitting up against flutter/flutter#29013

@dnfield dnfield merged commit 9e8f8d0 into flutter:master Mar 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 10, 2019
…8087) (#29115)

flutter/engine@2134286...9e8f8d0

git log 2134286..9e8f8d0 --no-merges --oneline
9e8f8d0 Drop android_sdk_downloader in favor of cipd (flutter/engine#8087)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop
the roller if necessary.
@dnfield dnfield deleted the cipd_ndk branch March 10, 2019 05:11
@jdunn010
Copy link

ran into a problem trying to fetch the ndk dependency. not sure what i am doing wrong, any suggestion much appreciated!

`ubuntu-18.04@ip:~/engine$ gclient sync
Syncing projects: 100% (90/90), done.

________ running 'cipd ensure -log-level error -root /home/ubuntu/engine -ensure-file /tmp/tmpzxvmWX.ensure' in '.'
[P18934 01:31:27.259 client.go:1375 E] cipd: failed to fetch flutter/android/ndk/linux-amd64:4PIz5-1td4npawLNyYi6H15qa0WjEVeY5dBDS68c_SAC - failed to download the package file after multiple attempts
[P18934 01:31:27.290 client.go:1560 E] Failed to install flutter/android/ndk/linux-amd64:4PIz5-1td4npawLNyYi6H15qa0WjEVeY5dBDS68c_SAC - failed to download the package file after multiple attempts
Error: failed to update packages, see the log.
Error: Command 'cipd ensure -log-level error -root /home/ubuntu/engine -ensure-file /tmp/tmpzxvmWX.ensure' returned non-zero exit status 1
`

@dnfield
Copy link
Contributor Author

dnfield commented Mar 24, 2019

I've seen that when Google cloud had an issue last week. Do you have the full logs?

@jdunn010
Copy link

i think it may actually have been some sort of "user error". I deleted the .cipd directory and re-ran to pull logs for you and it seems to have worked fine! Thanks a lot for such quick response and fixing it!
This is where it ended up, so I think it is all ok:

---------------------------------------- ________ running '/usr/bin/python src/build/landmines.py' in '/home/ubuntu/engine' ________ running '/usr/bin/python src/tools/dart/update.py' in '/home/ubuntu/engine' ________ running '/usr/bin/python src/flutter/tools/android_support/download_android_support.py' in '/home/ubuntu/engine' ________ running '/usr/bin/python src/tools/buildtools/update.py' in '/home/ubuntu/engine' Bootstrapping cipd client for linux-amd64... ######################################################################### 100.0%######################################################################### 100.0% Hook '/usr/bin/python src/tools/buildtools/update.py' took 63.13 secs ________ running '/usr/bin/python flutter/tools/generate_package_files.py' in '/home/ubuntu/engine/src/' ________ running '/usr/bin/python src/tools/remove_stale_pyc_files.py src/tools' in '/home/ubuntu/engine'

@dnfield
Copy link
Contributor Author

dnfield commented Mar 24, 2019

It may have just been a temporary service failure too. Glad it's working now

RBogie pushed a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
* remove sdk downloader, use cipd

* roll buildroot to drop android_sdk_downloader
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
najeira pushed a commit to najeira/flutter-engine that referenced this pull request Apr 12, 2019
* remove sdk downloader, use cipd

* roll buildroot to drop android_sdk_downloader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants