New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop android_sdk_downloader in favor of cipd #8087
Conversation
This will fail until we either rebuild the GKE container or land #8098 It's hitting up against flutter/flutter#29013 |
…8087) (#29115) flutter/engine@2134286...9e8f8d0 git log 2134286..9e8f8d0 --no-merges --oneline 9e8f8d0 Drop android_sdk_downloader in favor of cipd (flutter/engine#8087) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop the roller if necessary.
ran into a problem trying to fetch the ndk dependency. not sure what i am doing wrong, any suggestion much appreciated! `ubuntu-18.04@ip:~/engine$ gclient sync ________ running 'cipd ensure -log-level error -root /home/ubuntu/engine -ensure-file /tmp/tmpzxvmWX.ensure' in '.' |
I've seen that when Google cloud had an issue last week. Do you have the full logs? |
i think it may actually have been some sort of "user error". I deleted the .cipd directory and re-ran to pull logs for you and it seems to have worked fine! Thanks a lot for such quick response and fixing it!
|
It may have just been a temporary service failure too. Glad it's working now |
* remove sdk downloader, use cipd * roll buildroot to drop android_sdk_downloader
This reverts commit 3f0cf88.
This reverts commit 3f0cf88.
* remove sdk downloader, use cipd * roll buildroot to drop android_sdk_downloader
Fixes flutter/flutter#27967
CIPD was actually much easier to implement for this than I initially thought. I've created the packages for Linux and Mac here: https://chrome-infra-packages.appspot.com/p/flutter/android
I've also added bash scripts to help with creating new ones in the future.