Pass environment defines to compile flutter platform step. #8412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-siva
approved these changes
Apr 2, 2019
lib/snapshot/BUILD.gn
Outdated
| } | ||
| } | ||
|
|
||
| compile_flutter_platform("non_strong_platform") { | ||
| outputs = [ | ||
| "$root_out_dir/flutter_patched_sdk/platform.dill", | ||
| "$root_out_dir/flutter_patched_sdk/vm_outline.dill", | ||
| ] |
There was a problem hiding this comment.
Can we drop the non strong version, It should not be used anywhere.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2019
flutter/engine@4a8c7dc...cc11550 git log 4a8c7dc..cc11550 --no-merges --oneline cc11550 Roll src/third_party/skia c9eeab3d85b9..e25b4472cdd9 (1 commits) (flutter/engine#8420) 20e4599 Roll src/third_party/skia 71c0e9422038..c9eeab3d85b9 (4 commits) (flutter/engine#8418) a650790 Add scroll wheel support to desktop GLFW shell (flutter/engine#8416) 77d8e12 Roll src/third_party/dart 14fd3b7d6a..f6768b6fb3 (5 commits) 23fceaa Added new Android embedding packages to javadoc generation. (flutter/engine#8411) 2f17860 Pass environment defines to compile flutter platform step. (flutter/engine#8412) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…lutter#8412)" This reverts commit e5ce02d.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…lutter#8412)" This reverts commit e5ce02d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes environment defines to the compiler as needed for constant evaluation and removes redundant non-strong platform target.