Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose pointer type and buttons in embedder.h #9034

Merged
merged 2 commits into from
May 22, 2019
Merged

Expose pointer type and buttons in embedder.h #9034

merged 2 commits into from
May 22, 2019

Commits on May 21, 2019

  1. Expose pointer type and buttons in embedder.h 

    Rather than hard-coding the type of incoming events to mouse, and
synthesizing a primary button press for kDown/kUp, expose device kind
and buttons in the API.

For backwards compatibility, if the type is not set, the old behavior is
used. If an embedder sets the type to mouse explicitly, however, they
must also set correct button information.

For the touch type, the API abstracts away the framework's internal
expectation that a button is set for touch down/move for simplicity.
    @stuartmorgan
    stuartmorgan committed May 21, 2019
    Configuration menu
    Copy the full SHA
    586bd25 View commit details
    Browse the repository at this point in the history

  2. Update comments per review feedback

    @stuartmorgan
    stuartmorgan committed May 21, 2019
    Configuration menu
    Copy the full SHA
    ca299fc View commit details
    Browse the repository at this point in the history