Fix type mismatches in C++ standard codec #9112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some implicit casts in the standard codec implementation that didn't show up on Linux, but do on Windows.
jason-simmons
approved these changes
May 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2019
This was referenced May 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2019
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2019
* 49b6de8 Dynamically add certain iOS AppDelegate methods. (flutter/engine#8843) * 75da3d4 Roll src/third_party/dart fee615c5a5..39ec9fc4f3 (46 commits) * ba6cc8c Fix type mismatches in C++ standard codec (flutter/engine#9112) * 37b31ca Roll src/third_party/skia 69aaee0ff927..f62e575bab08 (11 commits) (flutter/engine#9142)
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
There were some implicit casts in the standard codec implementation that didn't show up on Linux, but do on Windows.
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
* 49b6de8 Dynamically add certain iOS AppDelegate methods. (flutter/engine#8843) * 75da3d4 Roll src/third_party/dart fee615c5a5..39ec9fc4f3 (46 commits) * ba6cc8c Fix type mismatches in C++ standard codec (flutter/engine#9112) * 37b31ca Roll src/third_party/skia 69aaee0ff927..f62e575bab08 (11 commits) (flutter/engine#9142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some implicit casts in the standard codec implementation that
didn't show up on Linux, but do on Windows.