New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Embedding Refactor PR32: Clean up logs in new embedding. #9351
Android Embedding Refactor PR32: Clean up logs in new embedding. #9351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is highly subjective and they're already marked as verbose so I'm not blocking merging the PR on this, but for what it's worth the verbose logs here would be total noise to me if I were trying to debug something in these classes. I'd want to go through the source code myself (or ideally attach a debugger) first to really grok how the parts aligned in detail in order to make sense of the method names from logcat, and at that point I'd either already have a debugger to check the execution path or I'd be able to add logs myself to specific interesting codepaths while I was reading through them myself. Just looking at a chain of method names in logcat on its own would probably be too much info to be useful, since I wouldn't be able to tell what was normal and what was potentially off and relevant to the specific thing I was looking into.
@mklim if it's worth a discussion, feel free to grab me. As one who generally knows the pieces in the embedding, I've found that these messages illuminate the order that things are happening, which can be difficult to track mentally. They're verbose so that unless you really want them, you don't need to see them. But if there is a way to make the logs more useful then I'm happy to talk it over. |
Some of these logs show up in my terminal during a regular
Was that intentional? They feel like spam. |
Android Embedding Refactor PR32: Clean up logs in new embedding.
This PR:
Log
usages in the new embedding to theio.flutter.Log
proxyAddress #33544 and #33102