Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin separating macOS engine from view controller #9654

Merged

Conversation

@stuartmorgan
Copy link
Contributor

commented Jul 2, 2019

Creates an initial, minimal FLEEngine that parallels the iOS
FlutterEngine, and moves engine launch, plugin registration, and binary
messenger functionality from FLEViewController to there. Uses the FLE
prefix since the current APIs will change to better match FlutterEngine;
the current APIs are intended to minimize conceptual changes relative to
the current FLEViewController APIs since it's already a substantial
change.

Further changes will move channels from FLEViewController to FLEEngine,
and further align the APIs and functionality with the iOS version.

Part of #32421

stuartmorgan added 3 commits Jul 2, 2019
Creates an initial, minimal FLEEngine that parallels the iOS
FlutterEngine, and moves engine launch, plugin registration, and binary
messenger functionality from FLEViewController to there. Uses the FLE
prefix since the current APIs will change to better match FlutterEngine;
the current APIs are intended to minimize conceptual changes relative to
the current FLEViewController APIs since it's already a substantial
change.

Further changes will move channels from FLEViewController to FLEEngine,
and futher align the APIs and functionality with the iOS version.
@stuartmorgan stuartmorgan requested a review from franciscojma86 Jul 2, 2019
@googlebot googlebot added the cla: yes label Jul 2, 2019
@stuartmorgan stuartmorgan merged commit 8dac2e9 into flutter:master Jul 3, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
build_and_test_host Task Summary
Details
build_and_test_host
Details
build_and_test_host_profile Task Summary
Details
build_and_test_host_profile
Details
build_and_test_host_release Task Summary
Details
build_and_test_host_release
Details
build_android Task Summary
Details
build_android
Details
build_windows_debug Task Summary
Details
build_windows_debug
Details
build_windows_debug_unopt Task Summary
Details
build_windows_debug_unopt
Details
cla/google All necessary CLAs are signed
format_and_dart_test Task Summary
Details
format_and_dart_test
Details
luci-engine
Details
@stuartmorgan stuartmorgan deleted the stuartmorgan:macos-flutter-engine-initial branch Jul 3, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jul 4, 2019
flutter/engine@7d3e722...3c51a7b

git log 7d3e722349e7923115f0b8800022a08c8dd795b3..3c51a7bfff776e9e3011384f4ff09c13a697c6b6 --no-merges --oneline
3c51a7bff Roll src/third_party/skia 11eb847a2080..857c9f955edb (2 commits) (flutter/engine#9676)
7f828dd3e Raster now returns an enum rather than boolean (flutter/engine#9661)
11b6afe00  Roll src/third_party/dart 67ab3be10d...b5aeaa6796 (flutter/engine#9675)
3c4dbe223 Revert " Roll src/third_party/dart 67ab3be10d...43891316ca (#9670)" (flutter/engine#9673)
5e596f2ac  Roll src/third_party/dart 67ab3be10d...43891316ca (flutter/engine#9670)
46a2239b4 Roll src/third_party/skia 5b52c52141ac..11eb847a2080 (6 commits) (flutter/engine#9671)
b84f89b44 Allow embedders to add callbacks for responses to platform messages from the framework. (flutter/engine#9655)
8dac2e979 Begin separating macOS engine from view controller (flutter/engine#9654)
d3616c7a3 Roll src/third_party/skia 0e0113dcbd9a..5b52c52141ac (8 commits) (flutter/engine#9665)
cea2c3617 Mutators Stack refactoring (flutter/engine#9663)
6a8782fe0 Roll src/third_party/skia 93eeff578b08..0e0113dcbd9a (9 commits) (flutter/engine#9662)
791143f17 ExternalViewEmbedder can CancelFrame after pre-roll (flutter/engine#9660)
d637f291a External view embedder can tell if embedded views have mutated (flutter/engine#9653)
ceee3d733 Roll src/third_party/skia 38ae3f42fec1..93eeff578b08 (1 commits) (flutter/engine#9659)
d75729006 Roll src/third_party/skia febc162c7898..38ae3f42fec1 (3 commits) (flutter/engine#9658)
58133abce Roll src/third_party/skia 3de5c6388142..febc162c7898 (2 commits) (flutter/engine#9657)
29342dd30 Roll src/third_party/skia 1e2cb444e0c1..3de5c6388142 (8 commits) (flutter/engine#9656)
b5473560d Pipeline allows continuations that can produce to front (flutter/engine#9652)
8306ee68c Move the mutators stack handling to preroll (flutter/engine#9651)
511b9f23a Roll src/third_party/skia 215ff3325230..1e2cb444e0c1 (12 commits) (flutter/engine#9650)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
wxCUHK added a commit to wxCUHK/engine that referenced this pull request Jul 4, 2019
Creates an initial, minimal FLEEngine that parallels the iOS
FlutterEngine, and moves engine launch, plugin registration, and binary
messenger functionality from FLEViewController to there. Uses the FLE
prefix since the current APIs will change to better match FlutterEngine;
the current APIs are intended to minimize conceptual changes relative to
the current FLEViewController APIs since it's already a substantial
change.

Further changes will move channels from FLEViewController to FLEEngine,
and further align the APIs and functionality with the iOS version.

Part of #32421
tango5614 added a commit to tango5614/flutter that referenced this pull request Jul 9, 2019
flutter/engine@7d3e722...3c51a7b

git log 7d3e722349e7923115f0b8800022a08c8dd795b3..3c51a7bfff776e9e3011384f4ff09c13a697c6b6 --no-merges --oneline
3c51a7bff Roll src/third_party/skia 11eb847a2080..857c9f955edb (2 commits) (flutter/engine#9676)
7f828dd3e Raster now returns an enum rather than boolean (flutter/engine#9661)
11b6afe00  Roll src/third_party/dart 67ab3be10d...b5aeaa6796 (flutter/engine#9675)
3c4dbe223 Revert &flutter#34; Roll src/third_party/dart 67ab3be10d...43891316ca (flutter#9670)&flutter#34; (flutter/engine#9673)
5e596f2ac  Roll src/third_party/dart 67ab3be10d...43891316ca (flutter/engine#9670)
46a2239b4 Roll src/third_party/skia 5b52c52141ac..11eb847a2080 (6 commits) (flutter/engine#9671)
b84f89b44 Allow embedders to add callbacks for responses to platform messages from the framework. (flutter/engine#9655)
8dac2e979 Begin separating macOS engine from view controller (flutter/engine#9654)
d3616c7a3 Roll src/third_party/skia 0e0113dcbd9a..5b52c52141ac (8 commits) (flutter/engine#9665)
cea2c3617 Mutators Stack refactoring (flutter/engine#9663)
6a8782fe0 Roll src/third_party/skia 93eeff578b08..0e0113dcbd9a (9 commits) (flutter/engine#9662)
791143f17 ExternalViewEmbedder can CancelFrame after pre-roll (flutter/engine#9660)
d637f291a External view embedder can tell if embedded views have mutated (flutter/engine#9653)
ceee3d733 Roll src/third_party/skia 38ae3f42fec1..93eeff578b08 (1 commits) (flutter/engine#9659)
d75729006 Roll src/third_party/skia febc162c7898..38ae3f42fec1 (3 commits) (flutter/engine#9658)
58133abce Roll src/third_party/skia 3de5c6388142..febc162c7898 (2 commits) (flutter/engine#9657)
29342dd30 Roll src/third_party/skia 1e2cb444e0c1..3de5c6388142 (8 commits) (flutter/engine#9656)
b5473560d Pipeline allows continuations that can produce to front (flutter/engine#9652)
8306ee68c Move the mutators stack handling to preroll (flutter/engine#9651)
511b9f23a Roll src/third_party/skia 215ff3325230..1e2cb444e0c1 (12 commits) (flutter/engine#9650)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
johnsonmh added a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@7d3e722...3c51a7b

git log 7d3e722349e7923115f0b8800022a08c8dd795b3..3c51a7bfff776e9e3011384f4ff09c13a697c6b6 --no-merges --oneline
3c51a7bff Roll src/third_party/skia 11eb847a2080..857c9f955edb (2 commits) (flutter/engine#9676)
7f828dd3e Raster now returns an enum rather than boolean (flutter/engine#9661)
11b6afe00  Roll src/third_party/dart 67ab3be10d...b5aeaa6796 (flutter/engine#9675)
3c4dbe223 Revert &flutter#34; Roll src/third_party/dart 67ab3be10d...43891316ca (flutter#9670)&flutter#34; (flutter/engine#9673)
5e596f2ac  Roll src/third_party/dart 67ab3be10d...43891316ca (flutter/engine#9670)
46a2239b4 Roll src/third_party/skia 5b52c52141ac..11eb847a2080 (6 commits) (flutter/engine#9671)
b84f89b44 Allow embedders to add callbacks for responses to platform messages from the framework. (flutter/engine#9655)
8dac2e979 Begin separating macOS engine from view controller (flutter/engine#9654)
d3616c7a3 Roll src/third_party/skia 0e0113dcbd9a..5b52c52141ac (8 commits) (flutter/engine#9665)
cea2c3617 Mutators Stack refactoring (flutter/engine#9663)
6a8782fe0 Roll src/third_party/skia 93eeff578b08..0e0113dcbd9a (9 commits) (flutter/engine#9662)
791143f17 ExternalViewEmbedder can CancelFrame after pre-roll (flutter/engine#9660)
d637f291a External view embedder can tell if embedded views have mutated (flutter/engine#9653)
ceee3d733 Roll src/third_party/skia 38ae3f42fec1..93eeff578b08 (1 commits) (flutter/engine#9659)
d75729006 Roll src/third_party/skia febc162c7898..38ae3f42fec1 (3 commits) (flutter/engine#9658)
58133abce Roll src/third_party/skia 3de5c6388142..febc162c7898 (2 commits) (flutter/engine#9657)
29342dd30 Roll src/third_party/skia 1e2cb444e0c1..3de5c6388142 (8 commits) (flutter/engine#9656)
b5473560d Pipeline allows continuations that can produce to front (flutter/engine#9652)
8306ee68c Move the mutators stack handling to preroll (flutter/engine#9651)
511b9f23a Roll src/third_party/skia 215ff3325230..1e2cb444e0c1 (12 commits) (flutter/engine#9650)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.