Skip to content

Commit

Permalink
Upload frame_request_pending_latency [attempt #2] (#135890)
Browse files Browse the repository at this point in the history
These values are generated since #135279, but I didn't know to add the new keys to this list to get them to upload. 

Failed to do so in #135645, I believe the mistake there was putting them in `_kCommonScoreKeys`, which is also used in "E2E" tests, that don't get full trace data, only high level `FrameTiming` packets.

Part of #129150
  • Loading branch information
moffatman committed Oct 5, 2023
1 parent 32bd280 commit 2925525
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions dev/devicelab/lib/tasks/perf_tests.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1300,6 +1300,9 @@ class PerfTest {
'average_vsync_transitions_missed',
'90th_percentile_vsync_transitions_missed',
'99th_percentile_vsync_transitions_missed',
'average_frame_request_pending_latency',
'90th_percentile_frame_request_pending_latency',
'99th_percentile_frame_request_pending_latency',
if (measureCpuGpu && !isAndroid) ...<String>[
// See https://github.com/flutter/flutter/issues/68888
if (data['average_cpu_usage'] != null) 'average_cpu_usage',
Expand Down
6 changes: 6 additions & 0 deletions dev/devicelab/test/perf_tests_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ void main() {
'average_vsync_transitions_missed': 1,
'90th_percentile_vsync_transitions_missed': 1,
'99th_percentile_vsync_transitions_missed': 1,
'average_frame_request_pending_latency': 0.1,
'90th_percentile_frame_request_pending_latency': 0.1,
'99th_percentile_frame_request_pending_latency': 0.1,
};
const String resultFileName = 'fake_result';
void driveCallback(List<String> arguments) {
Expand Down Expand Up @@ -108,6 +111,9 @@ void main() {
'90hz_frame_percentage': 0.4,
'120hz_frame_percentage': 0.6,
'illegal_refresh_rate_frame_count': 10,
'average_frame_request_pending_latency': 0.1,
'90th_percentile_frame_request_pending_latency': 0.1,
'99th_percentile_frame_request_pending_latency': 0.1,
};
const String resultFileName = 'fake_result';
void driveCallback(List<String> arguments) {
Expand Down

0 comments on commit 2925525

Please sign in to comment.