Skip to content

Commit

Permalink
annotate usages of SemanticsUpdateBuilderNew with `ignore: deprecat…
Browse files Browse the repository at this point in the history
…ed_member_use`
  • Loading branch information
bartekpacia committed Dec 8, 2023
1 parent d26b453 commit 36bcac5
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/flutter/lib/src/semantics/binding.dart
Expand Up @@ -2,13 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// ignore: deprecated_member_use
import 'dart:ui' as ui show AccessibilityFeatures, SemanticsActionEvent, SemanticsUpdateBuilderNew;

import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart';

import 'debug.dart';

// ignore: deprecated_member_use
export 'dart:ui' show AccessibilityFeatures, SemanticsActionEvent, SemanticsUpdateBuilderNew;

/// The glue between the semantics layer and the Flutter engine.
Expand Down Expand Up @@ -160,7 +162,9 @@ mixin SemanticsBinding on BindingBase {
///
/// This method is used by the [SemanticsOwner] to create builder for all its
/// semantics updates.
// ignore: deprecated_member_use
ui.SemanticsUpdateBuilderNew createSemanticsUpdateBuilder() {
// ignore: deprecated_member_use
return ui.SemanticsUpdateBuilderNew();
}

Expand Down
3 changes: 3 additions & 0 deletions packages/flutter/lib/src/semantics/semantics.dart
Expand Up @@ -3,6 +3,7 @@
// found in the LICENSE file.

import 'dart:math' as math;
// ignore: deprecated_member_use
import 'dart:ui' show Offset, Rect, SemanticsAction, SemanticsFlag, SemanticsUpdate, SemanticsUpdateBuilderNew, StringAttribute, TextDirection;

import 'package:collection/collection.dart';
Expand Down Expand Up @@ -2749,6 +2750,7 @@ class SemanticsNode with DiagnosticableTreeMixin {
static final Int32List _kEmptyCustomSemanticsActionsList = Int32List(0);
static final Float64List _kIdentityTransform = _initIdentityTransform();

// ignore: deprecated_member_use
void _addToUpdate(SemanticsUpdateBuilderNew builder, Set<int> customSemanticsActionIdsUpdate) {
assert(_dirty);
final SemanticsData data = getSemanticsData();
Expand Down Expand Up @@ -3442,6 +3444,7 @@ class SemanticsOwner extends ChangeNotifier {
}
}
visitedNodes.sort((SemanticsNode a, SemanticsNode b) => a.depth - b.depth);
// ignore: deprecated_member_use
final SemanticsUpdateBuilderNew builder = SemanticsBinding.instance.createSemanticsUpdateBuilder();
for (final SemanticsNode node in visitedNodes) {
assert(node.parent?._dirty != true); // could be null (no parent) or false (not dirty)
Expand Down
3 changes: 3 additions & 0 deletions packages/flutter/test/semantics/semantics_update_test.dart
Expand Up @@ -172,12 +172,15 @@ void main() {

class SemanticsUpdateTestBinding extends AutomatedTestWidgetsFlutterBinding {
@override
// ignore: deprecated_member_use
ui.SemanticsUpdateBuilderNew createSemanticsUpdateBuilder() {
return SemanticsUpdateBuilderSpy();
}
}

// ignore: deprecated_member_use
class SemanticsUpdateBuilderSpy extends Fake implements ui.SemanticsUpdateBuilderNew {
// ignore: deprecated_member_use
final SemanticsUpdateBuilderNew _builder = ui.SemanticsUpdateBuilderNew();

static Map<int, SemanticsNodeUpdateObservation> observations = <int, SemanticsNodeUpdateObservation>{};
Expand Down
1 change: 1 addition & 0 deletions packages/flutter_test/test/view_test.dart
Expand Up @@ -313,6 +313,7 @@ void main() {
});

testWidgets('updateSemantics is passed through to backing FlutterView', (WidgetTester tester) async {
// ignore: deprecated_member_use
final SemanticsUpdate expectedUpdate = SemanticsUpdateBuilderNew().build();
final _FakeFlutterView backingView = _FakeFlutterView();
final TestFlutterView view = TestFlutterView(
Expand Down

0 comments on commit 36bcac5

Please sign in to comment.