set environment variable to build mode when running asset transformer…

… process
flutter · Mar 11, 2024 · 579912d · 579912d
1 parent 8d69875
commit 579912d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/packages/flutter_tools/lib/src/build_system/targets/assets.dart b/packages/flutter_tools/lib/src/build_system/targets/assets.dart
@@ -102,6 +102,7 @@ Future<Depfile> copyAssets(
     processManager: environment.processManager,
     fileSystem: environment.fileSystem,
     dartBinaryPath: environment.artifacts.getArtifactPath(Artifact.engineDartBinary),
+    buildMode: buildMode,
   );
 
   final Map<String, AssetBundleEntry> assetEntries = <String, AssetBundleEntry>{

diff --git a/packages/flutter_tools/lib/src/build_system/tools/asset_transformer.dart b/packages/flutter_tools/lib/src/build_system/tools/asset_transformer.dart
@@ -12,6 +12,7 @@ import '../../base/error_handling_io.dart';
 import '../../base/file_system.dart';
 import '../../base/io.dart';
 import '../../base/logger.dart';
+import '../../build_info.dart';
 import '../../devfs.dart';
 import '../../flutter_manifest.dart';
 import '../build_system.dart';
@@ -22,13 +23,18 @@ final class AssetTransformer {
     required ProcessManager processManager,
     required FileSystem fileSystem,
     required String dartBinaryPath,
+    required BuildMode buildMode,
   })  : _processManager = processManager,
         _fileSystem = fileSystem,
-        _dartBinaryPath = dartBinaryPath;
+        _dartBinaryPath = dartBinaryPath,
+        _buildMode = buildMode;
+
+  static const String buildModeEnvVar = 'FLUTTER_BUILD_MODE';
 
   final ProcessManager _processManager;
   final FileSystem _fileSystem;
   final String _dartBinaryPath;
+  final BuildMode _buildMode;
 
   /// The [Source] inputs that targets using this should depend on.
   ///
@@ -115,6 +121,9 @@ final class AssetTransformer {
     final ProcessResult result = await _processManager.run(
       command,
       workingDirectory: workingDirectory,
+      environment: <String, String>{
+        AssetTransformer.buildModeEnvVar: _buildMode.cliName,
+      }
     );
     final String stdout = result.stdout as String;
     final String stderr = result.stderr as String;

diff --git a/packages/flutter_tools/test/general.shard/build_system/targets/asset_transformer_test.dart b/packages/flutter_tools/test/general.shard/build_system/targets/asset_transformer_test.dart
@@ -8,6 +8,7 @@ import 'package:file_testing/file_testing.dart';
 import 'package:flutter_tools/src/artifacts.dart';
 import 'package:flutter_tools/src/base/file_system.dart';
 import 'package:flutter_tools/src/base/logger.dart';
+import 'package:flutter_tools/src/build_info.dart';
 import 'package:flutter_tools/src/build_system/tools/asset_transformer.dart';
 import 'package:flutter_tools/src/flutter_manifest.dart';
 
@@ -53,6 +54,7 @@ void main() {
       processManager: processManager,
       fileSystem: fileSystem,
       dartBinaryPath: artifacts.getArtifactPath(Artifact.engineDartBinary),
+      buildMode: BuildMode.debug,
     );
 
     final AssetTransformationFailure? transformationFailure = await transformer.transformAsset(
@@ -112,6 +114,7 @@ void main() {
       processManager: processManager,
       fileSystem: fileSystem,
       dartBinaryPath: dartBinaryPath,
+      buildMode: BuildMode.debug,
     );
 
     final AssetTransformationFailure? failure = await transformer.transformAsset(
@@ -171,6 +174,7 @@ Something went wrong''');
       processManager: processManager,
       fileSystem: fileSystem,
       dartBinaryPath: dartBinaryPath,
+      buildMode: BuildMode.debug,
     );
 
     final AssetTransformationFailure? failure = await transformer.transformAsset(
@@ -265,6 +269,7 @@ Transformation failed, but I forgot to exit with a non-zero code.'''
       processManager: processManager,
       fileSystem: fileSystem,
       dartBinaryPath: dartBinaryPath,
+      buildMode: BuildMode.debug,
     );
 
     final AssetTransformationFailure? failure = await transformer.transformAsset(
@@ -331,14 +336,18 @@ Transformation failed, but I forgot to exit with a non-zero code.'''
         onRun: (List<String> args) {
           // Do nothing.
         },
-        stderr: 'Transformation failed, but I forgot to exit with a non-zero code.'
+        stderr: 'Transformation failed, but I forgot to exit with a non-zero code.',
+        environment: const <String, String>{
+          'FLUTTER_BUILD_MODE': 'debug',
+        },
       ),
     ]);
 
     final AssetTransformer transformer = AssetTransformer(
       processManager: processManager,
       fileSystem: fileSystem,
       dartBinaryPath: dartBinaryPath,
+      buildMode: BuildMode.debug,
     );
 
     final AssetTransformationFailure? failure = await transformer.transformAsset(