Skip to content

Commit

Permalink
[iOS,macOS] Clean up obsolete PlatformView warning (#135040)
Browse files Browse the repository at this point in the history
PlatformViews have been supported without a custom engine build on iOS
for quite some time now, and are nearing support for macOS. Adds a link
to the website documentation covering creation of PlatformViews for iOS
and adds a TODO to do the same once the macOS PlatformView documentation
is ready.

Related: flutter/website#9424
  • Loading branch information
cbracken committed Sep 23, 2023
1 parent 70fd335 commit 6379648
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions packages/flutter/lib/src/services/platform_views.dart
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,7 @@ class PlatformViewsService {
return controller;
}

// TODO(amirh): reference the iOS plugin API for registering a UIView factory
// once it lands.

/// This is work in progress, not yet ready to be used, and requires a custom
/// engine build. Creates a controller for a new iOS UIView.
/// Factory method to create a `UiKitView`.
///
/// The `id` parameter is an unused unique identifier generated with
/// [platformViewsRegistry].
Expand All @@ -218,6 +214,8 @@ class PlatformViewsService {
/// The `onFocus` parameter is a callback that will be invoked when the UIKit
/// view asks to get the input focus. If `creationParams` is non null then
/// `creationParamsCodec` must not be null.
///
/// See: https://docs.flutter.dev/platform-integration/ios/platform-views
static Future<UiKitViewController> initUiKitView({
required int id,
required String viewType,
Expand Down Expand Up @@ -249,6 +247,8 @@ class PlatformViewsService {
return UiKitViewController._(id, layoutDirection);
}

// TODO(cbracken): Write and link website docs. https://github.com/flutter/website/issues/9424.
//
/// Factory method to create an `AppKitView`.
///
/// The `id` parameter is an unused unique identifier generated with
Expand Down

0 comments on commit 6379648

Please sign in to comment.