5722a96 Roll src/third_party/dart 651d19cdaa25d020b8f7c193c9076442840…

…29130..f0c7d971c472066e29a949aab8826c204cfbaf35 (80 commits) f0c7d971c4 [dart2js] Run dartfmt --fix-doc-comments a9ce969e53 [vm] Decouple growable_array.h and zone.h from thread.h d821a2ec96 [vm/aot/tfa] Correctly tree shake initializers of write-only fields 602aa203b2 [vm/compiler] AOT bounds check elimination 3c5501a090 Add the experiment flags for the control flow and spread collection features 71e62a6016 [gardening] mark standalone_2/io/stdout_stderr_non_blocking_test as flaky e636e1fa6f Accept experimental flags in dart2js and enable set-literal tests, now supported once we accept the flag. 7cea3cba29 Several dump-info fixes. bbc6e2dd6f [VM/Compiler] Add some missing results for inlines. e329a830da [VM/AOT] Fix shared spilling stubs on arm/arm64 and enable it 5a1e01b7c9 [gardening] mark lib_2/isolate/unresolved_ports_test as flaky 3ef595bb56 [VM/Compiler] Separate out inlined code from replacement result. 68ad94cebe Extract more hint tests into separate files 47e988b781 Clean up the remaining copyright notices in analysis_server ea9303566b [vm] Allow choosing architecture for runtime sources in generate_idefiles.py. 1842020a69 Fix empty set/map literal disambiguation rule. 6a756ac040 Add front-end test for set/map literal disambiguation. 76be911f22 Enable set literals by default in the front-end tests. 02bb4379a2 Added specification of new style function types, generalized typedefs b631eb9b2f [gardening] Mark io/http_server_close_response_after_error_test as flaky 03098c1505 Implement DillClassBuilder.mixedInType 4547066f4b Tweak Declaration API c3b13ae5c1 Collect abstract members immediately instead of counting. deb9239790 Compute type arguments of dill types. c41611d35b Add non-final fields to setters b61a085c60 Use custom thisType to signal static type precision. 9157bbcf19 [kernel] Add text (de)serialization for VariableSet ba75b4c437 Revert "Change default target to "create_sdk"." 736ac8469d Use correct way of enabling blobs on dartk-bare-{simarm,simarm64} 1314a6dbf7 [Kernel] Do not evaluate fromEnvironment constants 90d22365d1 Convenience function to parse a list of experimental flags 7b2aae5498 Handle dynamic/instance access in ir/impact.dart 5cb13961db Use typeEnvironment.nullType for `null` and custom type for 'does not complete' 5340fea835 Move more parts of impact builder to ir/impact.dart cff0d20247 Use better static types for RuntimeTypeUse 944984f015 [Kernel] Add syntax for unevaluated constants 3d7ca147a4 Add FeaturesDataInterpreter d9c5bc131d [VM] Use --use-blobs for dartk-precomp-simarm/simarm64 builders 3f90e88288 first cut adding simple non-nullable migration to dartfix 16e98d012d Update BasicWorkspace's docs and tests 03be1858e7 [vm, gc] Use the correct trap instruction when zapping ARM/ARM64 code space. e2e2a85744 [dart2js] Add --no-minify flag for compiler devs bb4da7890b [gen_snapshot] Fixes for x86 Flutter code push. fc67a19feb js_runtime: Fix bit mask to match comments a1ff5f7cd5 Ensure inlining of getter/setters is recorded in our source-map extension d44ec3a57e Remove full emitter version of Function.apply 60cf393ff3 [dartdevc] fix to pass in analysis options to analysis context c34f1b4890 [vm] Bind static calls before saving JIT snapshots. 161f9b35c7 Use preparsed experiment status in Static Type Analyzer f043f296ef [vm] More modulo tests. 29b34fa63f Set nullability for TypeName(s) based of ClassElement. bb025bfac4 Use target file in CREATE_CONSTRUCTOR fixes. 5966565f0e Re-sort file and move TODO to where it was originally 4ef8de99ac Remove full emitter 8719fb3a7b Generate homebrew script compatible with latest changes edb68daa2c DateTime decimal separator: Added ',' version to regex and docs, added unit tests 6712dca7d8 Fix the test used to differentiate between empty sets and empty maps c76fa45178 Add an analysis server diagnostics page for LSP capabilities and completions 4a80990758 Implement LSP textDocument/documentHighlight 44449e29d2 Add a custom toJson snippet for LSP ResponseMessage for null handling 7e0d65706f Include null in allowed types for `any` and prefer null to omitting values if allowed 59b252fa0a [kernel] Add text serializer/deserializer for VariableGet 0bb0072f5f [infra] Add vm-kernel-precomp-android builder to the test matrix d908743de1 update_homebrew: initial cleanup e0ede8791f Fasta: Set fileEndOffset on Fields fe079b31b0 [tools] Fix list of possible arguments for -a in --help. 705701951a Small cleanup in incremental compiler 05673b80fc Suggest uploading dill file when failing to initialize from dill 457a7355f5 [vm] Use Util::Abs instead of std::abs. 89d3276703 Revert regexp_kill_test which is flaky on all platforms. d00f1e7e8e Introduce kernel based impact builder 0109e39ca4 Report INVALID_ASSIGNMENT for prefix/postfix increment decrement when the result is not assignable to the operand. e7495724b9 Remove TypeEnvironment.hierarchy 8e5ad9b3bd Prepare the VM for removing TypeEnvironment.hierarchy 7ac495e02a Prepare DDC for removing TypeEnvironment.hierarchy ca9ea997bd Fix old treatment of {}, enable set literals tests 7e3f4516b8 Allow crashes on fasta compiler co19_2 tests of Constant-update2018. Needed to turn ci bot green. 3c9e2cf8c9 Update front-end compiler status for co19_2 tests 8da53e3120 [vm] Add Dart_SaveTypeFeedback and Dart_LoadTypeFeedback. 9f2e614e98 [fuchsia] Just use dlopen like on other OSes (#26451)

flutter/engine@35daf14...5722a96

git log 35daf14..5722a96 --no-merges --oneline
5722a96 Roll src/third_party/dart 651d19cdaa25d020b8f7c193c907644284029130..f0c7d971c472066e29a949aab8826c204cfbaf35 (80 commits) f0c7d971c4 [dart2js] Run dartfmt --fix-doc-comments a9ce969e53 [vm] Decouple growable_array.h and zone.h from thread.h d821a2ec96 [vm/aot/tfa] Correctly tree shake initializers of write-only fields 602aa203b2 [vm/compiler] AOT bounds check elimination 3c5501a090 Add the experiment flags for the control flow and spread collection features 71e62a6016 [gardening] mark standalone_2/io/stdout_stderr_non_blocking_test as flaky e636e1fa6f Accept experimental flags in dart2js and enable set-literal tests, now supported once we accept the flag. 7cea3cba29 Several dump-info fixes. bbc6e2dd6f [VM/Compiler] Add some missing results for inlines. e329a830da [VM/AOT] Fix shared spilling stubs on arm/arm64 and enable it 5a1e01b7c9 [gardening] mark lib_2/isolate/unresolved_ports_test as flaky 3ef595bb56 [VM/Compiler] Separate out inlined code from replacement result. 68ad94cebe Extract more hint tests into separate files 47e988b781 Clean up the remaining copyright notices in analysis_server ea9303566b [vm] Allow choosing architecture for runtime sources in generate_idefiles.py. 1842020a69 Fix empty set/map literal disambiguation rule. 6a756ac040 Add front-end test for set/map literal disambiguation. 76be911f22 Enable set literals by default in the front-end tests. 02bb4379a2 Added specification of new style function types, generalized typedefs b631eb9b2f [gardening] Mark io/http_server_close_response_after_error_test as flaky 03098c1505 Implement DillClassBuilder.mixedInType 4547066f4b Tweak Declaration API c3b13ae5c1 Collect abstract members immediately instead of counting. deb9239790 Compute type arguments of dill types. c41611d35b Add non-final fields to setters b61a085c60 Use custom thisType to signal static type precision. 9157bbcf19 [kernel] Add text (de)serialization for VariableSet ba75b4c437 Revert "Change default target to "create_sdk"." 736ac8469d Use correct way of enabling blobs on dartk-bare-{simarm,simarm64} 1314a6dbf7 [Kernel] Do not evaluate fromEnvironment constants 90d22365d1 Convenience function to parse a list of experimental flags 7b2aae5498 Handle dynamic/instance access in ir/impact.dart 5cb13961db Use typeEnvironment.nullType for `null` and custom type for 'does not complete' 5340fea835 Move more parts of impact builder to ir/impact.dart cff0d20247 Use better static types for RuntimeTypeUse 944984f015 [Kernel] Add syntax for unevaluated constants 3d7ca147a4 Add FeaturesDataInterpreter d9c5bc131d [VM] Use --use-blobs for dartk-precomp-simarm/simarm64 builders 3f90e88288 first cut adding simple non-nullable migration to dartfix 16e98d012d Update BasicWorkspace's docs and tests 03be1858e7 [vm, gc] Use the correct trap instruction when zapping ARM/ARM64 code space. e2e2a85744 [dart2js] Add --no-minify flag for compiler devs bb4da7890b [gen_snapshot] Fixes for x86 Flutter code push. fc67a19feb js_runtime: Fix bit mask to match comments a1ff5f7cd5 Ensure inlining of getter/setters is recorded in our source-map extension d44ec3a57e Remove full emitter version of Function.apply 60cf393ff3 [dartdevc] fix to pass in analysis options to analysis context c34f1b4890 [vm] Bind static calls before saving JIT snapshots. 161f9b35c7 Use preparsed experiment status in Static Type Analyzer f043f296ef [vm] More modulo tests. 29b34fa63f Set nullability for TypeName(s) based of ClassElement. bb025bfac4 Use target file in CREATE_CONSTRUCTOR fixes. 5966565f0e Re-sort file and move TODO to where it was originally 4ef8de99ac Remove full emitter 8719fb3a7b Generate homebrew script compatible with latest changes edb68daa2c DateTime decimal separator: Added ',' version to regex and docs, added unit tests 6712dca7d8 Fix the test used to differentiate between empty sets and empty maps c76fa45178 Add an analysis server diagnostics page for LSP capabilities and completions 4a80990758 Implement LSP textDocument/documentHighlight 44449e29d2 Add a custom toJson snippet for LSP ResponseMessage for null handling 7e0d65706f Include null in allowed types for `any` and prefer null to omitting values if allowed 59b252fa0a [kernel] Add text serializer/deserializer for VariableGet 0bb0072f5f [infra] Add vm-kernel-precomp-android builder to the test matrix d908743de1 update_homebrew: initial cleanup e0ede8791f Fasta: Set fileEndOffset on Fields fe079b31b0 [tools] Fix list of possible arguments for -a in --help. 705701951a Small cleanup in incremental compiler 05673b80fc Suggest uploading dill file when failing to initialize from dill 457a7355f5 [vm] Use Util::Abs instead of std::abs. 89d3276703 Revert regexp_kill_test which is flaky on all platforms. d00f1e7e8e Introduce kernel based impact builder 0109e39ca4 Report INVALID_ASSIGNMENT for prefix/postfix increment decrement when the result is not assignable to the operand. e7495724b9 Remove TypeEnvironment.hierarchy 8e5ad9b3bd Prepare the VM for removing TypeEnvironment.hierarchy 7ac495e02a Prepare DDC for removing TypeEnvironment.hierarchy ca9ea997bd Fix old treatment of {}, enable set literals tests 7e3f4516b8 Allow crashes on fasta compiler co19_2 tests of  Constant-update2018.  Needed to turn ci bot green. 3c9e2cf8c9 Update front-end compiler status for co19_2 tests 8da53e3120 [vm] Add Dart_SaveTypeFeedback and Dart_LoadTypeFeedback. 9f2e614e98 [fuchsia] Just use dlopen like on other OSes

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.

bin/internal/engine.version

@@ -1 +1 @@
-35daf143b1f313977b92137283d2792d3be6f16f
+5722a9685e3cba77649ba5257a91ed21933ca063