Fetch tags for version command (#52212)

flutter · Mar 14, 2020 · 98cf018 · 98cf018
1 parent bbc5b9d
commit 98cf018
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/packages/flutter_tools/lib/src/commands/version.dart b/packages/flutter_tools/lib/src/commands/version.dart
@@ -41,6 +41,7 @@ class VersionCommand extends FlutterCommand {
   Version minSupportedVersion = Version.parse('1.2.1');
 
   Future<List<String>> getTags() async {
+    globals.flutterVersion.fetchTagsAndUpdate();
     RunResult runResult;
     try {
       runResult = await processUtils.run(

diff --git a/packages/flutter_tools/test/commands.shard/hermetic/version_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/version_test.dart
@@ -23,13 +23,15 @@ import '../../src/mocks.dart' show MockProcess;
 void main() {
   group('version', () {
     MockStdio mockStdio;
+    MockVersion mockVersion;
 
     setUpAll(() {
       Cache.disableLocking();
     });
 
     setUp(() {
       mockStdio = MockStdio();
+      mockVersion = MockVersion();
       when(mockStdio.stdinHasTerminal).thenReturn(false);
       when(mockStdio.hasTerminal).thenReturn(false);
     });
@@ -44,6 +46,7 @@ void main() {
     }, overrides: <Type, Generator>{
       ProcessManager: () => MockProcessManager(),
       Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext('version switch prompt is accepted', () async {
@@ -65,6 +68,7 @@ void main() {
       ProcessManager: () => MockProcessManager(),
       Stdio: () => mockStdio,
       AnsiTerminal: () => MockTerminal(),
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext('version switch prompt is declined', () async {
@@ -86,6 +90,7 @@ void main() {
       ProcessManager: () => MockProcessManager(),
       Stdio: () => mockStdio,
       AnsiTerminal: () => MockTerminal(),
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext('version switch, latest commit query fails', () async {
@@ -100,6 +105,7 @@ void main() {
     }, overrides: <Type, Generator>{
       ProcessManager: () => MockProcessManager(latestCommitFails: true),
       Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext('latest commit is parsable when query fails', () {
@@ -111,6 +117,7 @@ void main() {
     }, overrides: <Type, Generator>{
       ProcessManager: () => MockProcessManager(latestCommitFails: true),
       Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext('switch to not supported version without force', () async {
@@ -125,6 +132,7 @@ void main() {
     }, overrides: <Type, Generator>{
       ProcessManager: () => MockProcessManager(),
       Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext('switch to not supported version with force', () async {
@@ -140,6 +148,7 @@ void main() {
     }, overrides: <Type, Generator>{
       ProcessManager: () => MockProcessManager(),
       Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext('tool exit on confusing version', () async {
@@ -156,6 +165,7 @@ void main() {
     }, overrides: <Type, Generator>{
       ProcessManager: () => MockProcessManager(),
       Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext("exit tool if can't get the tags", () async {
@@ -169,6 +179,7 @@ void main() {
     }, overrides: <Type, Generator>{
       ProcessManager: () => MockProcessManager(failGitTag: true),
       Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
     });
 
     testUsingContext('Does not run pub when outside a project', () async {
@@ -180,10 +191,24 @@ void main() {
     }, overrides: <Type, Generator>{
       ProcessManager: () => MockProcessManager(),
       Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
+    });
+
+    testUsingContext('Fetches upstream tags', () async {
+      final VersionCommand command = VersionCommand();
+      await createTestCommandRunner(command).run(<String>[
+        'version',
+      ]);
+      verify(mockVersion.fetchTagsAndUpdate()).called(1);
+    }, overrides: <Type, Generator>{
+      ProcessManager: () => MockProcessManager(),
+      Stdio: () => mockStdio,
+      FlutterVersion: () => mockVersion,
     });
   });
 }
 
+class MockVersion extends Mock implements FlutterVersion {}
 class MockTerminal extends Mock implements AnsiTerminal {}
 class MockStdio extends Mock implements Stdio {}
 class MockProcessManager extends Mock implements ProcessManager {