Skip to content

Commit

Permalink
Don't use flutter_test in animated_icons_private_test. (#13917)
Browse files Browse the repository at this point in the history
This broke the coverage tool, as material/animated_icons/animated_icons.dart
was loaded twice as a part, once directly animated_icons_private_test, and one
through animated_icons_private_test->flutter_tester->...->material

The coverage package assumes a 1:1 mapping between VM scripts and URIs due to a
limitation in the underlying vm_service_client package, which currently doesn't
provide a unique identifier for VM scripts.

The underlying issue is tracked by dart-lang/coverage#194.
  • Loading branch information
amirh committed Jan 5, 2018
1 parent 8da5af5 commit 9ed652d
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ import 'dart:ui' as ui show Paint, Path, Canvas;

import 'package:flutter/animation.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:meta/meta.dart';
import 'package:mockito/mockito.dart';
import 'package:test/test.dart';

part 'package:flutter/src/material/animated_icons/animated_icons.dart';
part 'package:flutter/src/material/animated_icons/animated_icons_data.dart';
Expand Down

0 comments on commit 9ed652d

Please sign in to comment.