Apply review suggestions.

flutter · May 30, 2024 · e888493 · e888493
1 parent 53a8543
commit e888493
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 36 deletions.
diff --git a/examples/api/lib/widgets/tween_animation_builder/tween_animation_builder.0.dart b/examples/api/lib/widgets/tween_animation_builder/tween_animation_builder.0.dart
@@ -11,8 +11,6 @@ void main() => runApp(const TweenAnimationBuilderExampleApp());
 class TweenAnimationBuilderExampleApp extends StatelessWidget {
   const TweenAnimationBuilderExampleApp({super.key});
 
-  static const Duration duration = Duration(seconds: 1);
-
   @override
   Widget build(BuildContext context) {
     return MaterialApp(
@@ -29,12 +27,7 @@ class TweenAnimationBuilderExampleApp extends StatelessWidget {
 }
 
 class TweenAnimationBuilderExample extends StatefulWidget {
-  const TweenAnimationBuilderExample({
-    this.duration = TweenAnimationBuilderExampleApp.duration,
-    super.key,
-  });
-
-  final Duration duration;
+  const TweenAnimationBuilderExample({super.key});
 
   @override
   State<TweenAnimationBuilderExample> createState() =>
@@ -49,7 +42,7 @@ class _TweenAnimationBuilderExampleState
   Widget build(BuildContext context) {
     return TweenAnimationBuilder<double>(
       tween: Tween<double>(begin: 0, end: _targetValue),
-      duration: widget.duration,
+      duration: const Duration(seconds: 1),
       builder: (BuildContext context, double size, Widget? child) {
         return IconButton(
           iconSize: size,

diff --git a/examples/api/test/widgets/tween_animation_builder/tween_animation_builder.0_test.dart b/examples/api/test/widgets/tween_animation_builder/tween_animation_builder.0_test.dart
@@ -15,6 +15,9 @@ void main() {
       const example.TweenAnimationBuilderExampleApp(),
     );
 
+    // The animation duration defined in the example app.
+    const Duration animationDuration = Duration(seconds: 1);
+
     const double beginSize = 0.0;
     const double endSize = 24.0;
 
@@ -24,9 +27,7 @@ void main() {
     expect(iconButton.iconSize, equals(beginSize));
 
     // Advance animation to the middle.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(
@@ -35,9 +36,7 @@ void main() {
     );
 
     // Advance animation to the end.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(iconButton.iconSize, equals(endSize));
@@ -49,6 +48,9 @@ void main() {
     );
     await tester.pumpAndSettle();
 
+    // The animation duration defined in the example app.
+    const Duration animationDuration = Duration(seconds: 1);
+
     const double beginSize = 24.0;
     const double endSize = 48.0;
 
@@ -65,9 +67,7 @@ void main() {
     expect(iconButton.iconSize, equals(beginSize));
 
     // Advance animation to the middle.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(
@@ -76,9 +76,7 @@ void main() {
     );
 
     // Advance animation to the end.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(iconButton.iconSize, equals(endSize));
@@ -91,9 +89,7 @@ void main() {
     expect(iconButton.iconSize, equals(endSize));
 
     // Advance animation to the middle.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(
@@ -102,9 +98,7 @@ void main() {
     );
 
     // Advance animation to the end.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(iconButton.iconSize, equals(beginSize));
@@ -116,6 +110,9 @@ void main() {
     );
     await tester.pumpAndSettle();
 
+    // The animation duration defined in the example app.
+    const Duration animationDuration = Duration(seconds: 1);
+
     const double beginSize = 24.0;
     const double endSize = 48.0;
     final double middleSize = lerpDouble(beginSize, endSize, 0.5)!;
@@ -133,9 +130,7 @@ void main() {
     expect(iconButton.iconSize, equals(beginSize));
 
     // Advance animation to the middle.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(iconButton.iconSize, equals(middleSize));
@@ -148,9 +143,7 @@ void main() {
     expect(iconButton.iconSize, equals(middleSize));
 
     // Advance animation to the middle.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(
@@ -159,9 +152,7 @@ void main() {
     );
 
     // Advance animation to the end.
-    await tester.pump(
-      example.TweenAnimationBuilderExampleApp.duration ~/ 2,
-    );
+    await tester.pump(animationDuration ~/ 2);
 
     iconButton = tester.widget(iconButtonFinder);
     expect(iconButton.iconSize, equals(beginSize));