Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix data race in DartIsolateGroupData. (#15949)
This class is meant to be thread safe. In fact, its headerdoc statement on thread safety even mentions this. All fields on the class are readonly except the child isolate preparer. This field is set during VM instantiated isolate initialization. The VM may launch multiple isolate in the same isolate group on at the same time (each on a VM backed thread pool thread). Attempting to set the field without synchronization is a data race. Fixes #49358 Fixes b/147798920
- Loading branch information
1 parent
e08ff74
commit f10f03a
Showing
3 changed files
with
15 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters