Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScaffoldMessenger.showSnackBar doesn't check if there are any Scaffolds to present in #103004

Closed
Piinks opened this issue May 4, 2022 · 2 comments · Fixed by #103006 or #103426
Closed

ScaffoldMessenger.showSnackBar doesn't check if there are any Scaffolds to present in #103004

Piinks opened this issue May 4, 2022 · 2 comments · Fixed by #103006 or #103426
Assignees
@Piinks
Labels
a: error message Error messages from the Flutter framework f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@Piinks
Copy link
Contributor

Piinks commented May 4, 2022

Title!

You can call showSnackBar and have nothing happen if there is not a descendant Scaffold.
We should add an assertion to let folks know.
@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: error message Error messages from the Flutter framework labels May 4, 2022
@Piinks Piinks self-assigned this May 4, 2022
@Piinks Piinks mentioned this issue May 4, 2022
Merged
8 tasks
@Piinks Piinks reopened this May 5, 2022
@Piinks
Copy link
Contributor Author

Piinks commented May 5, 2022

The change was reverted, it looks like we caught some customer bugs that will need to be resolved first

@Piinks Piinks mentioned this issue May 10, 2022
Merged
8 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Piinks Piinks

Labels
a: error message Error messages from the Flutter framework f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
1 participant
@Piinks