New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assertion that snackbars have a place to go #103006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
f: material design
flutter/packages/flutter/material repository.
a: quality
A truly polished experience
a: error message
Error messages from the Flutter framework
labels
May 4, 2022
flutter-dashboard
bot
added
the
framework
flutter/packages/flutter repository. See also f: labels.
label
May 4, 2022
craiglabenz
approved these changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
home: Center(), | ||
)); | ||
|
||
final ScaffoldMessengerState scaffoldMessengerState = tester.state<ScaffoldMessengerState>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never seen tester.state
before!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 4, 2022
egramond
pushed a commit
to egramond/flutter
that referenced
this pull request
May 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2022
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: error message
Error messages from the Flutter framework
a: quality
A truly polished experience
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an assertion to ScaffoldMessenger.showSnackBar that makes sure the user will actually see the SnackBar. :)
Fixes #103004
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.