Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a smoke test for macOS desktop that verifies it can render #104283

Open
dnfield opened this issue May 20, 2022 · 1 comment
Open

Add a smoke test for macOS desktop that verifies it can render #104283

dnfield opened this issue May 20, 2022 · 1 comment
Labels
a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-mac Building on or for macOS specifically team-desktop Owned by Desktop platforms team triaged-desktop Triaged by Desktop platforms team

Comments

@dnfield
Copy link
Contributor

dnfield commented May 20, 2022

e.g. fill the window with some flat color and make sure the color shows up.

If the test runs in debug unopt mode, it would have caught the regression from #104154
@dnfield dnfield added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. platform-mac Building on or for macOS specifically a: desktop Running on desktop P2 Important issues not at the top of the work list labels May 20, 2022
@cbracken
Copy link
Member

Such a test would be convenient for testing the fix to #75388 as well.

@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-desktop Owned by Desktop platforms team triaged-desktop Triaged by Desktop platforms team labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-mac Building on or for macOS specifically team-desktop Owned by Desktop platforms team triaged-desktop Triaged by Desktop platforms team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbracken @Hixie @dnfield