[macOS][Desktop]: UI is broken on latest master

[darshankawar]

UI seems to be broken and not rendering on macOS desktop using latest master (Channel master, 3.1.0-0.0.pre.799, at the time of writing this).

Steps to replicate:

1. Create a new Flutter app (flutter create macos_issue)
2. cd macos_issue
3. flutter run -d macos and observe that UI is not rendered and shows a blank screen. If we try to resize the app window, then it shows flashes of the UI as we move the window size:

macos_desktop_broken.mov

The same works properly on latest stable (3.0) and beta (2.13.0-0.4.pre) as shown below:

macos_stable_rendering.mov

Moreover, this seems to be only happening on macOS desktop, whereas, macOS + web, macOS + android and Linux desktop seems to be working as expected.

master flutter doctor -v

[✓] Flutter (Channel master, 3.1.0-0.0.pre.799, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.1.0-0.0.pre.799 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 348a2b4f2f (29 minutes ago), 2022-05-19 00:33:08 -0400
    • Engine revision 1965c92ea4
    • Dart version 2.18.0 (build 2.18.0-130.0.dev)
    • DevTools version 2.13.1
    
[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[dkwingsmt]

I bisected to the framework commit 348a2b4, i.e. #104137.

[dkwingsmt]

And further engine bisection points to flutter/engine#33461. In fact, when running with a local engine, instead of showing a grey window, the app simply crashes. @dnfield

Other than fixing the issue, we should probably add some smoke test.

[dnfield]

Let's revert for now

[jmagman]

@cbracken mentioned writing more macOS tests...

[cbracken]

Indeed. There are many many many tests we need. We've been adding some, but desktop is pretty short-staffed right now. I'll gladly review patches if anyone wants to send them. :)

I just bisected this again without knowing it had already been bisected.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.