Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AndroidContextGl_MSAAx4 test is flaky #104463

Closed
blasten opened this issue May 24, 2022 · 6 comments
Closed

AndroidContextGl_MSAAx4 test is flaky #104463

blasten opened this issue May 24, 2022 · 6 comments
Labels
c: flake Tests that sometimes, but not always, incorrectly pass P2 Important issues not at the top of the work list platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@blasten
Copy link

blasten commented May 24, 2022

This test was added in flutter/engine@7b38d45, but it doesn't seem to be currently running.

I seem to be getting different values for sample_count every time this test is run.

Example log:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8813332198409600145/+/u/Android_Unit_Tests/stdout?format=raw

cc @dnfield
@blasten blasten added platform-android Android applications specifically team: flakes P2 Important issues not at the top of the work list labels May 24, 2022
@dnfield
Copy link
Contributor

dnfield commented May 24, 2022

Is this flaky or did it just never work on CI?

This seems to pass locally pretty consistently. It's possible that on CI, MSAA isn't available for the emulator.

@blasten
Copy link
Author

blasten commented May 24, 2022

did you test on an emulator or physical device? I used emulators in both.

@dnfield
Copy link
Contributor

dnfield commented May 24, 2022

Emulator.

@GaryQian
Copy link
Contributor

@dnfield Do we still want to re-enable the test?

@dnfield
Copy link
Contributor

dnfield commented Oct 26, 2022

No one is actually using this flag, and we'd likely need a physical device that we know supports MSAA to get this test re-enabled. I think this can be treated with low priority.

@flutter-triage-bot flutter-triage-bot bot added c: flake Tests that sometimes, but not always, incorrectly pass team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 7, 2023
@chinmaygarde
Copy link
Member

Obsoleted by #148257

@chinmaygarde chinmaygarde closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: flake Tests that sometimes, but not always, incorrectly pass P2 Important issues not at the top of the work list platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chinmaygarde @blasten @GaryQian @dnfield