Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete configuration of Settings::msaa_samples. #148257

Closed
chinmaygarde opened this issue May 13, 2024 · 1 comment · Fixed by flutter/engine#52780
Closed

Delete configuration of Settings::msaa_samples. #148257

chinmaygarde opened this issue May 13, 2024 · 1 comment · Fixed by flutter/engine#52780
Labels
c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team

Comments

@chinmaygarde
Copy link
Member

This was an experiment that didn't pan out. flutter/engine#32128 and associated code can be backed out.
@chinmaygarde chinmaygarde added c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team labels May 13, 2024
@chinmaygarde chinmaygarde mentioned this issue May 13, 2024
Closed
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue May 13, 2024
@chinmaygarde
Delete Settings::msaa_samples.
8b0e832 
Fixes flutter/flutter#148257
@chinmaygarde chinmaygarde mentioned this issue May 13, 2024
Merged
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue May 13, 2024
@chinmaygarde
Delete Settings::msaa_samples.
770c68e 
Fixes flutter/flutter#148257
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 13, 2024
@chinmaygarde
Delete Settings::msaa_samples. (#52780)
a1cdcb6 
Fixes flutter/flutter#148257
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete Settings::msaa_samples. chinmaygarde/flutter_engine
1 participant
@chinmaygarde