Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building a new_gallery with a local profile or release engine fails #104667

Open
dnfield opened this issue May 25, 2022 · 12 comments
Open

Building a new_gallery with a local profile or release engine fails #104667

dnfield opened this issue May 25, 2022 · 12 comments
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically t: gradle "flutter build" and "flutter run" on Android team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-android Triaged by Android platform team

Comments

@dnfield
Copy link
Contributor

dnfield commented May 25, 2022

But it succeeds if you remove the deferred components.

Seems like there's something wrong with deferred component logic when using a local engine.

This makes it harder to test performance experiments in local engine builds on Android.

@dnfield dnfield added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine repository. See also e: labels. t: gradle "flutter build" and "flutter run" on Android P2 Important issues not at the top of the work list labels May 25, 2022
@dnfield
Copy link
Contributor Author

dnfield commented May 25, 2022

/cc @GaryQian @christopherfujino @blasten in case one of you knows what's up

@GaryQian
Copy link
Contributor

This failure seems to fail at the gen_snapshot step, @rmacnak-google

@dnfield
Copy link
Contributor Author

dnfield commented May 25, 2022

I'm getting errors around it not finding the plugin related classes locally, e.g.

dnfield/.pub-cache/hosted/pub.dartlang.org/package_info_plus-1.4.2/android/src/main/kotlin/dev/fluttercommunity/plus/packageinfo/PackageInfoPlugin.kt: (23, 25): Unresolved reference: MethodChannel 

@GaryQian
Copy link
Contributor

Ahh, this may be different then Ill look.

@blasten
Copy link

blasten commented May 25, 2022

I'm using local engine and debug as I type, does it work if you use debug? I used profile a week or so ago with plugins.

@dnfield
Copy link
Contributor Author

dnfield commented May 25, 2022

Debug works, profile does not - but only if you have deferred app components (i.e. new_gallery)

@blasten
Copy link

blasten commented May 26, 2022

To unlock this, is it possible to remove the deferred component ?

@GaryQian
Copy link
Contributor

Yeah, you can build with the --no-deferred-components flag, The app will just build it into one single appbundle

@dnfield
Copy link
Contributor Author

dnfield commented May 26, 2022

It does mean that contributors can't run the same benchmark as on CI though.

@rmacnak-google
Copy link
Contributor

Where is new_gallery?

@dnfield
Copy link
Contributor Author

dnfield commented May 26, 2022

https://github.com/flutter/gallery

@rmacnak-google I don't think this is a gen_snapshot issue - I think there's some issue with Flutter's gradle build rules, where we might not be giving some part of the deferred component build the right JARs or something

@guidezpl
Copy link
Member

guidezpl commented Jun 3, 2023

Related: #97149 and flutter/gallery#926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically t: gradle "flutter build" and "flutter run" on Android team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-android Triaged by Android platform team
Projects
None yet
Development

No branches or pull requests

6 participants