Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gold service is flaky in post submit #108905

Closed
Piinks opened this issue Aug 3, 2022 · 6 comments
Closed

Gold service is flaky in post submit #108905

Piinks opened this issue Aug 3, 2022 · 6 comments
Assignees
Labels
a: tests "flutter test", flutter_test, or one of our tests c: flake Tests that sometimes, but not always, incorrectly pass framework flutter/packages/flutter repository. See also f: labels. P0 Critical issues such as a build break or regression team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team

Comments

@Piinks
Copy link
Contributor

Piinks commented Aug 3, 2022

Skia bug: https://bugs.chromium.org/p/skia/issues/detail?id=13621

We keep getting test failures for approved images on the master branch in post submit.
The reported failing image digests are actually positive image results when we go to the dashboard:

Here is one example of output:

01:26 +2277 ~14 -7: /opt/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/text_field_test.dart: Overflow clipBehavior none golden                                                                    
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following _Exception was thrown while running async test code:
Exception: Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/flutter are triaged
in pre-submit during code review for the given PR.

Visit https://flutter-gold.skia.org/ to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter

Debug information for Gold:
stdout: Given image with hash 00473a05465d2335a65840d025317772 for test
cupertino.overflow_clipbehavior_none.cupertino.0
Untriaged or negative image:
https://flutter-gold.skia.org/detail?test=cupertino.overflow_clipbehavior_none.cupertino.0&digest=00473a05465d2335a65840d025317772


stderr: Test: cupertino.overflow_clipbehavior_none.cupertino.0 FAIL

When the exception was thrown, this was the stack:
#0      SkiaGoldClient.imgtestAdd (package:flutter_goldens_client/skia_client.dart:218:7)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
════════════════════════════════════════════════════════════════════════════════════════════════════

01:26 +2277 ~14 -8: /opt/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/text_field_test.dart: Overflow clipBehavior none golden [E]                                                                
  Test failed. See exception logs above.
  The test description was: Overflow clipBehavior none golden

Following the link to the image test result shows an approved image though, so it is not clear why Gold says the test is failing.

Here are several builds where this has happened on multiple golden file tests:

https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_libraries/6123/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_widgets/6225/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_canvaskit_tests_3/3404/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_canvaskit_tests_7_last/3382/overview

When re-run, the test is passing. This flaky behavior is breaking our tree.

CC @kjlubick & @LeandroLovisolo

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. team: flakes team-infra Owned by Infrastructure team c: flake Tests that sometimes, but not always, incorrectly pass labels Aug 3, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Aug 3, 2022

Also, https://flutter-gold.skia.org/ shows there are no untriaged images in post submit.

@keyonghan
Copy link
Contributor

From triage: assigning to @Piinks for tracking.

@Piinks
Copy link
Contributor Author

Piinks commented Aug 9, 2022

We have not seen this flake since last Wednesday, but are continuing to monitor.

@Piinks
Copy link
Contributor Author

Piinks commented Aug 16, 2022

Weekly update, we have not seen this again another week later. If we are still free from flakes next week, I'll feel comfortable closing this.

@Piinks
Copy link
Contributor Author

Piinks commented Aug 23, 2022

This still has not reappeared, so I am going to close it.

@Piinks Piinks closed this as completed Aug 23, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
@flutter-triage-bot flutter-triage-bot bot added P0 Critical issues such as a build break or regression and removed P1 labels Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests c: flake Tests that sometimes, but not always, incorrectly pass framework flutter/packages/flutter repository. See also f: labels. P0 Critical issues such as a build break or regression team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
None yet
Development

No branches or pull requests

2 participants