Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog SkSL loading benchmarks and determine how/when to turn down for impeller #109002

Closed
jonahwilliams opened this issue Aug 4, 2022 · 2 comments · Fixed by #123163
Closed

Catalog SkSL loading benchmarks and determine how/when to turn down for impeller #109002

jonahwilliams opened this issue Aug 4, 2022 · 2 comments · Fixed by #123163
Assignees
@jonahwilliams
Labels
engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@jonahwilliams
Copy link
Member

Long term plans for the flutter engine involve removing the need to precompile shader warmup. This means that eventually we can fully turn down this functionality in the tooling and remove benchmarks from the devicelab. As a first step towards that, we should consider reducing the number of tests/shards devoted to SkSL benchmarking as impeller becomes more available.
@jonahwilliams jonahwilliams added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project labels Aug 4, 2022
@jonahwilliams jonahwilliams self-assigned this Aug 4, 2022
@chinmaygarde
Copy link
Member

xref #122207

@jonahwilliams jonahwilliams mentioned this issue Mar 21, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonahwilliams jonahwilliams

Labels
engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

delete sksl benchmarks jonahwilliams/flutter
2 participants
@chinmaygarde @jonahwilliams