Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] In Playground, implement a swap to Skia backend for comparison #109271

Closed
flar opened this issue Aug 9, 2022 · 3 comments
Closed

[Impeller] In Playground, implement a swap to Skia backend for comparison #109271

flar opened this issue Aug 9, 2022 · 3 comments
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@flar
Copy link
Contributor

flar commented Aug 9, 2022

Perhaps pressing 's' to quick swap to Skia while pressed and/or 'S' - one could swap while pressed, the other could toggle.

@flar flar added engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list e: impeller Impeller rendering backend issues and features requests labels Aug 9, 2022
@chinmaygarde
Copy link
Member

Good suggestion, we could parameterize the display list unittests harness to begin with.

@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
@chinmaygarde
Copy link
Member

Looking into this some more, I don't think this makes sense for any playground other than maybe the display list one because all other variants use Impeller specific APIs.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants