Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow engine_v2 recipes to fetch a build configuration from monorepo repository #110481

Open
whesse opened this issue Aug 29, 2022 · 3 comments
Open
Labels
team-infra Owned by Infrastructure team

Comments

@whesse
Copy link
Contributor

whesse commented Aug 29, 2022

As with the engine_v2 coordinator recipe engine_v2 when it runs a flutter/engine build, I would like
the coordinator to download the build properties for the monorepo builds from a .json configuration
file in the monorepo repository.

This can be done by adding flexibility to the build properties download step, so it checks out the monorepo repository
instead of the engine repository. Exactly the same check as is used in

https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine_v2/builder.py#207

can be added when downloading the config, to checkout monorepo instead of flutter/engine, and download from a path in that repo.

@whesse whesse added the team-infra Owned by Infrastructure team label Aug 29, 2022
@whesse whesse self-assigned this Aug 29, 2022
pbo-linaro pushed a commit to pbo-linaro/flutter-recipes that referenced this issue Nov 24, 2022
Bug: flutter/flutter#110481
Change-Id: I297785ebc106a9a1c938480884660de45d57a084
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/33200
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Casey Hillers <chillers@google.com>
@keyonghan
Copy link
Contributor

Has this been implemented?

@flutter-triage-bot flutter-triage-bot bot added the Bot is counting down the days until it unassigns the issue label May 16, 2024
@flutter-triage-bot
Copy link

This issue is assigned to @whesse but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@flutter-triage-bot
Copy link

This issue was assigned to @whesse but has had no status updates in a long time. To remove any ambiguity about whether the issue is being worked on, the assignee was removed.

@flutter-triage-bot flutter-triage-bot bot removed the Bot is counting down the days until it unassigns the issue label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-infra Owned by Infrastructure team
Projects
None yet
Development

No branches or pull requests

3 participants