Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gclient verify in CI before gclient sync, fix existing violations #113052

Open
jmagman opened this issue Oct 6, 2022 · 6 comments
Open

Run gclient verify in CI before gclient sync, fix existing violations #113052

jmagman opened this issue Oct 6, 2022 · 6 comments
Labels
P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team

Comments

@jmagman
Copy link
Member

jmagman commented Oct 6, 2022

Discovered during flutter/engine#36634 (comment), running gclient verify reports many violations, including that some of the engine DEPS hosts are not in allowed_hosts. Fix all existing violations, and update scripts to run gclient verify in CI before sync to prevent future violations from slipping in.

@godofredoc
Copy link
Contributor

@jmagman should infra coordinate with you for the engine side changes? if not @zanderso who should be a good POC in the engine side for these fixes?

@zanderso
Copy link
Member

zanderso commented Oct 6, 2022

This should be combined with the effort to stop pulling directly from GitHub.

@godofredoc
Copy link
Contributor

This is the bug tracking mirrors for reference: #110142

@godofredoc
Copy link
Contributor

Remaining violations:

src at https://github.com/flutter/buildroot.git@c9c2b77c9520903741ccda2fe12f773408a76c94
	src/third_party/benchmark at https://github.com/google/benchmark@431abd149fd76a072f821913c0340137cc755f36
	src/third_party/boringssl at https://github.com/dart-lang/boringssl_gen.git@ced85ef0a00bbca77ce5a91261a5f2ae61b1e62f
	src/third_party/flatbuffers at https://github.com/google/flatbuffers.git@0a80646371179f8a7a5c1f42c31ee1d44dcf6709
	src/third_party/googletest at https://github.com/google/googletest@054a986a8513149e8374fc669a5fe40117ca6b41
	src/third_party/imgui at https://github.com/ocornut/imgui.git@29d462ebce0275345a6ce4621d8fff0ded57c9e5
	src/third_party/json at https://github.com/nlohmann/json.git@17d9eacd248f58b73f4d1be518ef649fe2295642
	src/third_party/ocmock at https://github.com/erikdoe/ocmock.git@c4ec0e3a7a9f56cfdbd0aa01f4f97bb4b75c5ef8
	src/third_party/pkg/archive at https://github.com/brendan-duncan/archive.git@9de7a0544457c6aba755ccb65abb41b0dc1db70d
	src/third_party/pkg/equatable at https://github.com/felangel/equatable.git@0ba67c72db8bed75877fc1caafa74112ee0bd921
	src/third_party/pkg/flutter_packages at https://github.com/flutter/packages.git@26990a2f75ab2028c3c77ffc869db11d6d866d18
	src/third_party/pkg/gcloud at https://github.com/dart-lang/gcloud.git@a5276b85c4714378e84b1fb478b8feeeb686ac26
	src/third_party/pkg/googleapis at https://github.com/google/googleapis.dart.git@07f01b7aa6985e4cafd0fd4b98724841bc9e85a1
	src/third_party/pkg/platform at https://github.com/google/platform.dart.git@1ffad63428bbd1b3ecaa15926bacfb724023648c
	src/third_party/pkg/process at https://github.com/google/process.dart.git@0c9aeac86dcc4e3a6cf760b76fed507107e244d5
	src/third_party/pkg/process_runner at https://github.com/google/process_runner.git@d632ea0bfd814d779fcc53a361ed33eaf3620a0b
	src/third_party/pkg/quiver at https://github.com/google/quiver-dart.git@66f473cca1332496e34a783ba4527b04388fd561
	src/third_party/shaderc at https://github.com/google/shaderc.git@948660cccfbbc303d2590c7f44a4cee40b66fdd6
	src/third_party/tinygltf at https://github.com/syoyo/tinygltf.git@9bb5806df4055ac973b970ba5b3e27ce27d98148
	src/third_party/yapf at https://github.com/google/yapf@212c5b5ad8e172d2d914ae454c121c89cccbcb35

@Hixie
Copy link
Contributor

Hixie commented Aug 8, 2023

Today's violations:

There are deps from not allowed hosts in file DEPS
        src at https://github.com/flutter/buildroot.git@a067408d923ccf80742571bb7a71705499f5779e
        src/third_party/benchmark at https://github.com/google/benchmark@431abd149fd76a072f821913c0340137cc755f36
        src/third_party/boringssl at https://github.com/dart-lang/boringssl_gen.git@a468ba9fec3f59edf46a7db98caaca893e1e4d96
        src/third_party/flatbuffers at https://github.com/google/flatbuffers.git@0a80646371179f8a7a5c1f42c31ee1d44dcf6709
        src/third_party/googletest at https://github.com/google/googletest@054a986a8513149e8374fc669a5fe40117ca6b41
        src/third_party/imgui at https://github.com/ocornut/imgui.git@3ea0fad204e994d669f79ed29dcaf61cd5cb571d
        src/third_party/impeller-cmake-example at https://github.com/bdero/impeller-cmake-example.git@270e648f8c00aa900d2d16ef8a347938652d17fb
        src/third_party/json at https://github.com/nlohmann/json.git@17d9eacd248f58b73f4d1be518ef649fe2295642
        src/third_party/ocmock at https://github.com/erikdoe/ocmock.git@c4ec0e3a7a9f56cfdbd0aa01f4f97bb4b75c5ef8
        src/third_party/pkg/archive at https://github.com/brendan-duncan/archive.git@9de7a0544457c6aba755ccb65abb41b0dc1db70d
        src/third_party/pkg/equatable at https://github.com/felangel/equatable.git@0ba67c72db8bed75877fc1caafa74112ee0bd921
        src/third_party/pkg/flutter_packages at https://github.com/flutter/packages.git@25454e63851fe7933f04d025606e68c1eac4fe0f
        src/third_party/pkg/gcloud at https://github.com/dart-lang/gcloud.git@a5276b85c4714378e84b1fb478b8feeeb686ac26
        src/third_party/pkg/googleapis at https://github.com/google/googleapis.dart.git@526011f56d98eab183cc6075ee1392e8303e43e2
        src/third_party/pkg/platform at https://github.com/google/platform.dart.git@1ffad63428bbd1b3ecaa15926bacfb724023648c
        src/third_party/pkg/process at https://github.com/google/process.dart.git@0c9aeac86dcc4e3a6cf760b76fed507107e244d5
        src/third_party/pkg/process_runner at https://github.com/google/process_runner.git@f24c69efdcaf109168f23d381fa281453d2bc9b1
        src/third_party/pkg/quiver at https://github.com/google/quiver-dart.git@90b92bee895e507d435012356a8b5c5f17eafa52
        src/third_party/shaderc at https://github.com/google/shaderc.git@7ea834ecc59258a5c13c3d3e6fa0582bdde7c543
        src/third_party/tinygltf at https://github.com/syoyo/tinygltf.git@9bb5806df4055ac973b970ba5b3e27ce27d98148
        src/third_party/yapf at https://github.com/google/yapf@212c5b5ad8e172d2d914ae454c121c89cccbcb35
allowed_hosts: chrome-infra-packages.appspot.com, fuchsia.googlesource.com, skia.googlesource.com, chromium.googlesource.com, dart.googlesource.com, swiftshader.googlesource.com, boringssl.googlesource.com, llvm.googlesource.com, flutter.googlesource.com

@Hixie Hixie added the fyi-engine For the attention of Engine team label Aug 8, 2023
@chinmaygarde chinmaygarde removed the fyi-engine For the attention of Engine team label Aug 14, 2023
@ricardoamador ricardoamador added P2 Important issues not at the top of the work list triaged-infra Triaged by Infrastructure team labels Aug 23, 2023
auto-submit bot pushed a commit to flutter/engine that referenced this issue Oct 17, 2023
harryterkelsen pushed a commit to flutter/engine that referenced this issue Oct 23, 2023
@jmagman
Copy link
Member Author

jmagman commented Feb 1, 2024

cc @sealesj working on mirrors and allowed_hosts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
None yet
Development

No branches or pull requests

6 participants