Codecov should only report on PRs with packages/flutter changes

[jmagman]

The script is only measuring packages/flutter test coverage, but that report is commenting on PRs with no changes to packages/flutter

flutter/.github/workflows/coverage.yml

Line 24 in bd4376c

run: pushd packages/flutter;../../bin/flutter test --coverage -j 1;popd

For example, my packages/flutter_tools PR reported there was no coverage change. #113585 (comment)

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths

[jmagman]

cc @godofredoc

[godofredoc]

Not sure why your PR got comments from codecov. The workflow is running on post-submit and not supposed to comment on PRs

[christopherfujino]

I'm thinking this might be leftover config from when we enabled this for tool PRs.

[jmagman]

Hmm, not sure either, push/branches looks correct from the documentation...

Created #113627 so it doesn't run on non-packages/flutter commits, even on post-submit.

[jmagman]

I'm thinking this might be leftover config from when we enabled this for tool PRs.

You mean I hit something transient with that PR and it's now resolved? If so we can close this and my PR and reopen if we see it again.

[godofredoc]

I would expect that, but I like that we are limiting the workflow to changes in the packages directory, it is currently very expensive to run on every commit (~90m).

[godofredoc]

Can we close this bug?

[jmagman]

SGTM, will reopen if I spot this again.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

[jmagman]

Hm I hit this again #114558 (comment)

[godofredoc]

Closing as non reproducible. Please reopen if you see this again.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.