Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Swift plugin Objective-C files #113585

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 18, 2022

Both Objective-C apps and Swift apps should be correctly @import/importing plugins as modules. https://github.com/flutter/flutter/pull/42204/files#r333285661

Remove the Objective-C code in the iOS plugins. This will now (mostly) match the macOS plugin:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/plugin/macos.tmpl/Classes/pluginClass.swift.tmpl

See conversation at flutter/plugins#6369 (comment).

Plugins are already pretty well integration tested, ex.


PluginTest('ios', <String>['-i', 'swift', '--platforms=ios']),

Fixes #111928

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the platform-ios iOS applications specifically label Oct 18, 2022
@jmagman jmagman self-assigned this Oct 18, 2022
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #113585 (2ea90ea) into master (d2d8902) will not change coverage.
The diff coverage is n/a.

❗ Current head 2ea90ea differs from pull request most recent head c5cf7c6. Consider uploading reports for the commit c5cf7c6 to get more accurate results

@@           Coverage Diff            @@
##           master   #113585   +/-   ##
========================================
  Coverage   91.45%    91.45%           
========================================
  Files         523       523           
  Lines       94639     94639           
========================================
  Hits        86549     86549           
  Misses       8090      8090           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmagman jmagman marked this pull request as ready for review October 18, 2022 17:50
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugins] remove ObjC wrapper in swift plugin templates
4 participants