Remove Swift plugin Objective-C files #113585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Objective-C apps and Swift apps should be correctly
@import
/import
ing plugins as modules. https://github.com/flutter/flutter/pull/42204/files#r333285661flutter/packages/flutter_tools/lib/src/flutter_plugins.dart
Line 491 in 2ea90ea
Remove the Objective-C code in the iOS plugins. This will now (mostly) match the macOS plugin:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/plugin/macos.tmpl/Classes/pluginClass.swift.tmpl
See conversation at flutter/plugins#6369 (comment).
Plugins are already pretty well integration tested, ex.
flutter/dev/devicelab/bin/tasks/plugin_dependencies_test.dart
Line 281 in 2ea90ea
flutter/dev/devicelab/bin/tasks/plugin_test_ios.dart
Line 11 in 2ea90ea
Fixes #111928
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.