Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge flutter/plugins into flutter/packages #113764

Closed
23 tasks done
stuartmorgan opened this issue Oct 20, 2022 · 2 comments
Closed
23 tasks done

Merge flutter/plugins into flutter/packages #113764

stuartmorgan opened this issue Oct 20, 2022 · 2 comments
Assignees
@stuartmorgan
Labels
P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Oct 20, 2022 •
edited
Loading

Tracking bug for implementing https://flutter.dev/go/flutter-plugins-repo-migration

  • Pre-align Dockerfile
  • Pre-align .cirrus.yaml
  • Pre-align .ci.yaml, .ci/scripts, and .ci/targets
    • Including making sure the generic recipes driving them are aligned after recent drift
  • Pre-align install_chromium.sh
  • Pre-align analysis_options.yaml
  • Pre-test a migration pattern for in-progress PRs, and write up a wiki page clearly documenting the steps.
  • Pre-test a history graft locally with git-filter-repo
  • Move repo tooling from flutter/plugins to flutter/packcages
  • Stop the flutter/flutter -> flutter/plugins roller
  • Update flutter/plugins README and CONTRIBUTING
  • Close all PRs in flutter/plugins with an explanation
  • Re-validate that pre-aligned configurations still match
  • Archive flutter/plugins
  • Update repository tooling to enforce that the ‘repository’ entry in pubspec.yaml points to flutter/packages, and fix all of the violations.
  • Land the PR to graft flutter/plugins history into flutter/packages
  • Update docs (flutter/packages docs, Flutter wiki) referencing flutter/packages
  • Update the flutter/flutter CI analysis of flutter/plugins to instead analyze flutter/packages
  • Update the Dart CI analysis of flutter/plugins to instead analyze flutter/packages
  • Fully turn down the flutter/flutter → flutter/plugins rollers
  • Update flutter/packages README, especially the package table
  • Update flutter/packages CONTRIBUTING docs
  • Update internal gardening docs
@stuartmorgan stuartmorgan added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin package flutter/packages repository. See also p: labels. P1 High-priority issues at the top of the work list labels Oct 20, 2022
@stuartmorgan stuartmorgan self-assigned this Oct 20, 2022
stuartmorgan added a commit to stuartmorgan/packages that referenced this issue Oct 21, 2022
@stuartmorgan
[ci] Enable the all_packages tasks
55ede23 
Adds the "build all packages together" tasks on all platforms. While
doing it on every platform isn't necessary for non-plugin packages, this
is part of pre-alignment with flutter/plugins in preparation for the
move. This is a light-weight task, so adding it in advance should not
cause significant overhead.

The command name and the output directory are still plugin-centric,
which is why the naming is sometimes "all packages" (everywhere the name
is part of a CI specification) and "all plugins" (when it's the tool
command or the directory created by the tool). The naming will be
cleaned up later; using the final task names now avoids task name
confusion (despite the name it builds all packages) and later churn in
tasks (especially LUCI where name changes require a `bringup` cycle).

Part of flutter/flutter#113764
@stuartmorgan stuartmorgan mentioned this issue Oct 21, 2022
Merged
11 tasks
stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Nov 21, 2022
@stuartmorgan
[ci] Import flutter/packages install_chromium.sh
6ac96c5 
Brings over the newer flutter/packages version of install_chromium.sh as
part of pre-aligning the repositories for later merging.

Part of flutter/flutter#113764
This was referenced Nov 21, 2022
Merged
Merged
Merged
auto-submit bot pushed a commit to flutter/plugins that referenced this issue Nov 22, 2022
@stuartmorgan @ditman
[ci] Import flutter/packages install_chromium.sh (#6727)
2a52394 
* [ci] Import flutter/packages install_chromium.sh

Brings over the newer flutter/packages version of install_chromium.sh as
part of pre-aligning the repositories for later merging.

Part of flutter/flutter#113764

* Update .cirrus.yml

Co-authored-by: David Iglesias <ditman@gmail.com>

Co-authored-by: David Iglesias <ditman@gmail.com>
josh88versa pushed a commit to versa-asia/plugins that referenced this issue Nov 23, 2022
@stuartmorgan @ditman @josh88versa
[ci] Import flutter/packages install_chromium.sh (flutter#6727)
ccd9494 
* [ci] Import flutter/packages install_chromium.sh

Brings over the newer flutter/packages version of install_chromium.sh as
part of pre-aligning the repositories for later merging.

Part of flutter/flutter#113764

* Update .cirrus.yml

Co-authored-by: David Iglesias <ditman@gmail.com>

Co-authored-by: David Iglesias <ditman@gmail.com>
@stuartmorgan stuartmorgan mentioned this issue Dec 14, 2022
Merged
11 tasks
This was referenced Jan 12, 2023
Merged
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jan 20, 2023
@stuartmorgan
[ci] Enable Windows build-all (#3054)
4fe8377 
These tests were added in bringup mode, but never fully enabled.

Part of flutter/flutter#113764
@stuartmorgan stuartmorgan mentioned this issue Jan 25, 2023
Merged
11 tasks
mauricioluz pushed a commit to mauricioluz/plugins that referenced this issue Jan 26, 2023
@stuartmorgan @ditman @mauricioluz
[ci] Import flutter/packages install_chromium.sh (flutter#6727)
2726854 
* [ci] Import flutter/packages install_chromium.sh

Brings over the newer flutter/packages version of install_chromium.sh as
part of pre-aligning the repositories for later merging.

Part of flutter/flutter#113764

* Update .cirrus.yml

Co-authored-by: David Iglesias <ditman@gmail.com>

Co-authored-by: David Iglesias <ditman@gmail.com>
This was referenced Jan 31, 2023
Merged
Merged
Merged
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jan 31, 2023
@stuartmorgan
[ci] Add .g.dart to analysis ignore list (#3130)
2d48415 
In preparation for merging repos, this adds the `.g.dart` suffix we use
for Pigeon-generated files in plugins to the analysis ignore list. This
eliminates the last remaining difference between the two repos' analysis
options.

Part of flutter/flutter#113764
auto-submit bot pushed a commit to flutter/packages that referenced this issue Feb 1, 2023
@stuartmorgan
[ci] Enable no_runtimeType_toString (#3129)
2e4224e 
Enables the `no_runtimeType_toString` analysis option. This isn't part
of the base flutter/flutter analysis options, but is set in
flutter/packages which this repo better corresponds to.

This is already enabled in flutter/plugins, and is being enabled here as
part of aligning their options.

Part of flutter/flutter#113764
auto-submit bot pushed a commit to flutter/plugins that referenced this issue Feb 1, 2023
@stuartmorgan
[ci] Clean up analysis options (#7068)
e41f9f9 
Removes some options that are no longer necessary, further aligning the
options with flutter/packages.

Part of flutter/flutter#113764
This was referenced Feb 1, 2023
Closed
Merged
Merged
@bparrishMines bparrishMines mentioned this issue Feb 2, 2023
Closed
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this issue Feb 4, 2023
@stuartmorgan @Maatteogekko
[ci] Enable Windows build-all (flutter#3054)
53d4e56 
These tests were added in bringup mode, but never fully enabled.

Part of flutter/flutter#113764
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this issue Feb 4, 2023
@stuartmorgan @Maatteogekko
[ci] Add .g.dart to analysis ignore list (flutter#3130)
1683d8a 
In preparation for merging repos, this adds the `.g.dart` suffix we use
for Pigeon-generated files in plugins to the analysis ignore list. This
eliminates the last remaining difference between the two repos' analysis
options.

Part of flutter/flutter#113764
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this issue Feb 4, 2023
@stuartmorgan @Maatteogekko
[ci] Enable no_runtimeType_toString (flutter#3129)
72e9899 
Enables the `no_runtimeType_toString` analysis option. This isn't part
of the base flutter/flutter analysis options, but is set in
flutter/packages which this repo better corresponds to.

This is already enabled in flutter/plugins, and is being enabled here as
part of aligning their options.

Part of flutter/flutter#113764
This was referenced Feb 10, 2023
Merged
Merged
stuartmorgan added a commit to flutter/packages that referenced this issue Feb 10, 2023
@stuartmorgan
[ci] Enable new LUCI tests (#3190)
840a6e3 
- Fixes a reference to the wrong repo's recipe due to a copy/paste mistake.
- Enables the tests added recently in bringup mode.
  - Except for one with a typo in the name; for that one, fixes the typo instead and I'll enable it after this lands.
- Removes the ARM build-all now that the Intel build-all is online.

Part of flutter/flutter#113764
This was referenced Feb 13, 2023
Merged
Merged
Closed
stuartmorgan added a commit to flutter/packages that referenced this issue Feb 13, 2023
@stuartmorgan
[ci] Migrate repo tooling from flutter/plugins (#3198)
c149b81 
Imports the repository tooling from flutter/plugins. This is being moved
in advance of the full repository merge in order to reduce the
complexity of the final merge, since it is highly separable from the
rest of the repository.

Rather than being a copy, this grafts the history of flutter/plugins's
script/tool directory (rewritten to exclude other directories), to
preserve `git blame` and related functionality. All of the commits here
except those from today are migrating the code as-is. My commits from
today:
- Replace all the CI usage of `flutter_plugin_tools` from pub with the
local copy, so that this PR tests the code being added.
- Updates documentation about the tool.
- Enables CI tests of the tool itself.
- Updates metadata for the tool (version, source repo).

Part of flutter/flutter#113764
This was referenced Feb 16, 2023
Merged
Merged
engine-flutter-autoroll pushed a commit to engine-flutter-autoroll/packages that referenced this issue Feb 22, 2023
@stuartmorgan
Merge flutter/plugins (flutter#3233)
2e16733 
Merges everything from the packages/ directory of flutter/plugins (which
is essentially the entire remaining repository) into this repository,
completing the core of the repository merge.

Part of flutter/flutter#113764
@stuartmorgan
Copy link
Contributor Author

Closing, as this is (essentially) done. The roller config updates are the last piece, and that's already being tracked separately.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan stuartmorgan

Labels
P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuartmorgan