Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Adds a release_candidate variable to DEPS #114266

Closed
godofredoc opened this issue Oct 28, 2022 · 6 comments
Closed

[CP] Adds a release_candidate variable to DEPS #114266

godofredoc opened this issue Oct 28, 2022 · 6 comments
Assignees
@CaseyHillers
Labels
cp: approved Approved cherry-pick request cp: review Cherry-picks in the review queue

Comments

@godofredoc
Copy link
Contributor

issue_link

#113931

Commit Hash

85f6a6fc604df2943d6f061c4ba95d2485131737

Target

stable

pr_link

flutter/engine#37132

Impacted Users

dart developers

Impact Description

This change is required to unblock dart sdk CP to hotfix branch.

Workaround

No workaround

Risk

low

Test Coverage

yes

Validation Steps

Automated tests on presubmit validate these changes.
@godofredoc godofredoc added the cp: review Cherry-picks in the review queue label Oct 28, 2022
@CaseyHillers
Copy link
Contributor

Can you link the recipes CP as well?

@CaseyHillers
Copy link
Contributor

Friendly ping. Today's the last day for engine PRs to be submitted to make this weeks release.

@godofredoc
Copy link
Contributor Author

CP to recipes branch: https://flutter-review.googlesource.com/c/recipes/+/35302

@CaseyHillers CaseyHillers added the cp: approved Approved cherry-pick request label Oct 31, 2022
@CaseyHillers
Copy link
Contributor

The CP request LGTM

@CaseyHillers CaseyHillers self-assigned this Oct 31, 2022
@CaseyHillers
Copy link
Contributor

This was released in 3.3.7

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CaseyHillers CaseyHillers

Labels
cp: approved Approved cherry-pick request cp: review Cherry-picks in the review queue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CaseyHillers @godofredoc